device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java - Issue 2183563002: Remove Context param from LocationUtils methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java

Issue 2183563002: Remove Context param from LocationUtils methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update BT Device Fakes class Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/location/android/java/src/org/chromium/components/location/LocationUtils.java ('k') | device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java

diff --git a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java

index 7367e2f62d534c635393432c18e145551bb9a519..ebc9dc659c0ac0ad0b0a92a6256210d4d11f984a 100644

--- a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java

+++ b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java

@@ -209,13 +209,9 @@ final class ChromeBluetoothAdapter extends BroadcastReceiver {

* are on.

private boolean canScan() {

- Context context = mAdapter.getContext();

- boolean havePermission = LocationUtils.getInstance().hasAndroidLocationPermission(context);

- boolean locationServicesOn =

- LocationUtils.getInstance().isSystemLocationSettingEnabled(context);

- return havePermission && locationServicesOn;

+ LocationUtils locationUtils = LocationUtils.getInstance();

+ return locationUtils.hasAndroidLocationPermission()

+ && locationUtils.isSystemLocationSettingEnabled();

}

private void registerBroadcastReceiver() {