Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2183533003: Fix the mobile emulator to use the correct device scale when disabled. (Closed)

Created:
4 years, 5 months ago by Bret
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501, 628185 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/2168313002 . Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Original-Commit-Position: refs/heads/master@{#407294} Cr-Commit-Position: refs/heads/master@{#407639} (cherry picked from commit 1c78b3850f956c1507e4cdf9429652ee0ef15cb0) Committed: https://chromium.googlesource.com/chromium/src/+/c00cb1de97175f2f023bd18b6792c9057de70dc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/renderer/devtools/render_widget_screen_metrics_emulator.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
4 years, 5 months ago (2016-07-26 00:33:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c00cb1de97175f2f023bd18b6792c9057de70dc1.

Powered by Google App Engine
This is Rietveld 408576698