Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2168313002:
Fix the mobile emulator to use the correct device scale when disabled. (Closed)
|
Created:
4 years, 5 months ago by Bret Modified:
4 years, 5 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, devtools-reviews_chromium.org, jam, pfeldman, darin-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix the mobile emulator to use the correct device scale when disabled.
The mobile emulator was triggering a layout before it had reapplied the
original viewport parameters when it was being disabled, which with
use-zoom-for-dsf enabled was causing the wrong viewport size to be given
to various components, like plugins and scrollbars.
BUG=628501, 628185
R=dgozman@chromium.org
Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f
Cr-Commit-Position: refs/heads/master@{#407294}
Committed: https://chromium.googlesource.com/chromium/src/+/1c78b3850f956c1507e4cdf9429652ee0ef15cb0
Patch Set 1 #Patch Set 2 : update screen orientation emulator layout test expectation #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 ========== to ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 ==========
bsep@chromium.org changed reviewers: + alph@chromium.org
alph@chromium.org changed reviewers: + dgozman@chromium.org
Dmitry, could you please take a look.
Could this also be a cause of https://bugs.chromium.org/p/chromium/issues/detail?id=628194? lgtm
On 2016/07/22 20:43:59, dgozman wrote: > Could this also be a cause of > https://bugs.chromium.org/p/chromium/issues/detail?id=628194? > > lgtm Plausibly yes but also plausibly no. I don't have a way to test Chrome OS, so after this lands maybe someone can recheck it.
The CQ bit was checked by bsep@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 ========== to ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 ========== to ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Commit-Position: refs/heads/master@{#407294} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Commit-Position: refs/heads/master@{#407294}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2174493004/ by mpearson@chromium.org. The reason for reverting is: Likely cause of webkit_tests unexpected_failures inspector/screen-orientation-override.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/678... Failure appeared on many bots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu... https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu... https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1... https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1... https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1... and it seems related (change to devtools, failure in "inspector").
Message was sent while issue was closed.
Description was changed from ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Commit-Position: refs/heads/master@{#407294} ========== to ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Commit-Position: refs/heads/master@{#407294} ==========
The CQ bit was checked by bsep@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2168313002/#ps20001 (title: "update screen orientation emulator layout test expectation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Commit-Position: refs/heads/master@{#407294} ========== to ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 R=dgozman@chromium.org Committed: https://crrev.com/1c78b3850f956c1507e4cdf9429652ee0ef15cb0 Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Original-Commit-Position: refs/heads/master@{#407294} Cr-Commit-Position: refs/heads/master@{#407639} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1c78b3850f956c1507e4cdf9429652ee0ef15cb0 Cr-Commit-Position: refs/heads/master@{#407639}
Message was sent while issue was closed.
Description was changed from ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 R=dgozman@chromium.org Committed: https://crrev.com/1c78b3850f956c1507e4cdf9429652ee0ef15cb0 Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Original-Commit-Position: refs/heads/master@{#407294} Cr-Commit-Position: refs/heads/master@{#407639} ========== to ========== Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG=628501,628185 R=dgozman@chromium.org Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Commit-Position: refs/heads/master@{#407294} Committed: https://chromium.googlesource.com/chromium/src/+/1c78b3850f956c1507e4cdf94296... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 1c78b3850f956c1507e4cdf9429652ee0ef15cb0. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
