Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2183453004: [Editing][CodeHealth] Remove redundant Editabletype arguments in EditingUtilities (Closed)

Created:
4 years, 4 months ago by yoichio
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][CodeHealth] Remove redundant Editabletype arguments in EditingUtilities They are always ContentIsEditable. TEST=No change in behavior Committed: https://crrev.com/5fe0003991c8605206c0eba9fffdf20233441873 Cr-Commit-Position: refs/heads/master@{#408050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
yoichio
4 years, 4 months ago (2016-07-26 06:06:06 UTC) #6
yosin_UTC9
lgtm Nice!
4 years, 4 months ago (2016-07-26 06:58:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183453004/1
4 years, 4 months ago (2016-07-27 02:15:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183453004/1
4 years, 4 months ago (2016-07-27 04:22:27 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 05:27:36 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 05:29:11 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fe0003991c8605206c0eba9fffdf20233441873
Cr-Commit-Position: refs/heads/master@{#408050}

Powered by Google App Engine
This is Rietveld 408576698