third_party/WebKit/Source/core/editing/EditingUtilities.h - Issue 2183453004: [Editing][CodeHealth] Remove redundant Editabletype arguments in EditingUtilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2183453004: [Editing][CodeHealth] Remove redundant Editabletype arguments in EditingUtilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/EditingUtilities.h

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.h b/third_party/WebKit/Source/core/editing/EditingUtilities.h

index c3cee9abada2c63ab410ea07012aa8c97abe6cce..eb781660dfe3821ba9b96d9f19c0392fc0e40768 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.h

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.h

@@ -80,7 +80,7 @@ CORE_EXPORT bool needsLayoutTreeUpdate(const Position&);

// defiance of editing boundaries. This returns a Document if designMode="on"

// and the specified Position is not in the <body>.

CORE_EXPORT ContainerNode* highestEditableRoot(const Position&, EditableType = ContentIsEditable);

-ContainerNode* highestEditableRoot(const PositionInFlatTree&, EditableType = ContentIsEditable);

+ContainerNode* highestEditableRoot(const PositionInFlatTree&);

Node* highestEnclosingNodeOfType(const Position&, bool (*nodeIsOfType)(const Node*),

EditingBoundaryCrossingRule = CannotCrossEditingBoundary, Node* stayWithin = nullptr);

@@ -309,7 +309,7 @@ HTMLSpanElement* createTabSpanElement(Document&);

HTMLSpanElement* createTabSpanElement(Document&, const String& tabText);

Element* rootEditableElementOf(const Position&, EditableType = ContentIsEditable);

-Element* rootEditableElementOf(const PositionInFlatTree&, EditableType = ContentIsEditable);

+Element* rootEditableElementOf(const PositionInFlatTree&);

Element* rootEditableElementOf(const VisiblePosition&);

Element* unsplittableElementForPosition(const Position&);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »