Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

Issue 2183423002: Only do security checks on javascript: URLs for frames for loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLFrameElementBase.h » ('j') | third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
index e61cc92d2e962e16d40e23e8ecd7b1dc39ebc64a..5c2f92003166aa655abac433989253654729023f 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameElement.cpp
@@ -44,7 +44,7 @@ DEFINE_NODE_FACTORY(HTMLFrameElement)
bool HTMLFrameElement::layoutObjectIsNeeded(const ComputedStyle&)
{
// For compatibility, frames render even when display: none is set.
- return isURLAllowed();
+ return isURLAllowed(WillNotLoadURL);
}
LayoutObject* HTMLFrameElement::createLayoutObject(const ComputedStyle&)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLFrameElementBase.h » ('j') | third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698