third_party/WebKit/Source/core/html/HTMLFrameElementBase.h - Issue 2183423002: Only do security checks on javascript: URLs for frames for loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

Issue 2183423002: Only do security checks on javascript: URLs for frames for loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

index 6e9cf68a0f36e9ced892fccaa58b264f6cf8f507..40250204fc91b1a5eeddc5d92310516fd82ea982 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

+++ b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

@@ -41,7 +41,8 @@ public:

protected:

HTMLFrameElementBase(const QualifiedName&, Document&);

- bool isURLAllowed() const;

+ enum ReasonForCallingURLAllowed { WillLoadURL, WillNotLoadURL };

+ bool isURLAllowed(ReasonForCallingURLAllowed) const;

void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;

InsertionNotificationRequest insertedInto(ContainerNode*) override;