Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: fpdfsdk/javascript/Icon.h

Issue 2183313004: Split fpdfdoc/include/fpdf_doc.h into individual classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rebase to master Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/javascript/Icon.h
diff --git a/fpdfsdk/javascript/Icon.h b/fpdfsdk/javascript/Icon.h
index bd125d8299b1af96fe8f05df3ad73117f3cfd59c..898cf5b3e9b409f5f24c9287d8bf13f2c99a413c 100644
--- a/fpdfsdk/javascript/Icon.h
+++ b/fpdfsdk/javascript/Icon.h
@@ -9,6 +9,8 @@
#include "fpdfsdk/javascript/JS_Define.h"
+class CPDF_Stream;
Lei Zhang 2016/07/28 19:27:02 BTW, did you know the Google C++ style guide chang
dsinclair 2016/07/28 19:42:14 Switching is probably a good idea for new code, di
Lei Zhang 2016/08/16 04:48:45 And I missed the memo on the Chromium style guide
+
class Icon : public CJS_EmbedObj {
public:
Icon(CJS_Object* pJSObject);
Lei Zhang 2016/07/28 19:27:02 explicit here and line 32.
dsinclair 2016/07/28 19:42:14 Done.

Powered by Google App Engine
This is Rietveld 408576698