Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2183033002: [turbofan] Run JSGenericLowering as separate phase. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run JSGenericLowering as separate phase. This works around the problem that the lowering for JSStackCheck doesn't play well with effect chain based state tracking, because it doesn't report the correct changes (we will address this with a better handling of stack checks soon). It also allows us to run the EarlyOptimizationPhase concurrently, which doesn't need to access the heap or generate code stubs. R=jarin@chromium.org Committed: https://crrev.com/bec00d246c048db92ceaa71bd08478f8d27e3a8b Cr-Commit-Position: refs/heads/master@{#38049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M src/compiler/pipeline.cc View 4 chunks +18 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-26 12:11:06 UTC) #1
Jarin
lgtm
4 years, 4 months ago (2016-07-26 12:12:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183033002/1
4 years, 4 months ago (2016-07-26 12:12:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 12:32:53 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 12:36:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bec00d246c048db92ceaa71bd08478f8d27e3a8b
Cr-Commit-Position: refs/heads/master@{#38049}

Powered by Google App Engine
This is Rietveld 408576698