Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2182973004: [turbofan] Track up to 32 fields for LoadElimination. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_GenericLowering
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Track up to 32 fields for LoadElimination. With the current approach we cannot eliminate context accesses in mid-size function contexts, so let's bump the limit a bit to make sure we can optimize those as well. R=jarin@chromium.org BUG=v8:4930, v8:5141 Committed: https://crrev.com/5c2d13a1ed7afce7d533d1f0609fba0c0a2e1149 Cr-Commit-Position: refs/heads/master@{#38050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/load-elimination.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-26 12:19:22 UTC) #1
Jarin
lgtm
4 years, 4 months ago (2016-07-26 12:36:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182973004/1
4 years, 4 months ago (2016-07-26 12:36:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 12:40:10 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 12:43:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c2d13a1ed7afce7d533d1f0609fba0c0a2e1149
Cr-Commit-Position: refs/heads/master@{#38050}

Powered by Google App Engine
This is Rietveld 408576698