Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2182933002: [gn] Set reasonable defaults for debugging (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Set reasonable defaults for debugging BUG=chromium:474921 Committed: https://crrev.com/7e1867d664412f08c0072dce5013d0892ef30753 Cr-Commit-Position: refs/heads/master@{#38048}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M BUILD.gn View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Yang
https://codereview.chromium.org/2182933002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2182933002/diff/1/BUILD.gn#newcode88 BUILD.gn:88: v8_object_print = is_debug && !v8_optimized_debug also set v8_enable_disassembler please
4 years, 4 months ago (2016-07-26 09:01:20 UTC) #3
Michael Achenbach
PTAL
4 years, 4 months ago (2016-07-26 09:24:50 UTC) #5
Yang
On 2016/07/26 09:24:50, Michael Achenbach (slow) wrote: > PTAL lgtm. Thanks!
4 years, 4 months ago (2016-07-26 09:31:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182933002/20001
4 years, 4 months ago (2016-07-26 11:05:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5666) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-07-26 11:19:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182933002/20001
4 years, 4 months ago (2016-07-26 11:37:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 12:00:22 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 12:01:46 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7e1867d664412f08c0072dce5013d0892ef30753
Cr-Commit-Position: refs/heads/master@{#38048}

Powered by Google App Engine
This is Rietveld 408576698