Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: BUILD.gn

Issue 2182933002: [gn] Set reasonable defaults for debugging (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b737883542b372d4cf7e2b7aa95f6fc45b1483d3..4a00d4999d654aa34f3a9033b7afb2a41671a47e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -32,7 +32,7 @@ declare_args() {
v8_embed_script = ""
# Sets -dENABLE_DISASSEMBLER.
- v8_enable_disassembler = false
+ v8_enable_disassembler = ""
# Sets -dENABLE_GDB_JIT_INTERFACE.
v8_enable_gdbjit = ""
@@ -52,7 +52,7 @@ declare_args() {
v8_interpreted_regexp = false
# Sets -dOBJECT_PRINT.
- v8_object_print = false
+ v8_object_print = ""
# With post mortem support enabled, metadata is embedded into libv8 that
# describes various parameters of the VM for use by debuggers. See
@@ -83,6 +83,14 @@ if (v8_enable_gdbjit == "") {
}
}
+# Derived defaults.
+if (v8_object_print == "") {
+ v8_object_print = is_debug && !v8_optimized_debug
+}
+if (v8_enable_disassembler == "") {
+ v8_enable_disassembler = is_debug && !v8_optimized_debug
+}
+
v8_generated_peephole_source = "$target_gen_dir/bytecode-peephole-table.cc"
v8_random_seed = "314159265"
v8_toolset_for_shell = "host"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698