Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: build/config/arm.gni

Issue 2182473002: gn: Default to softfp for V8 arm simulator builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/arm.gni
diff --git a/build/config/arm.gni b/build/config/arm.gni
index cc468d89e18e21b0c123d6fa9476a008471f0474..75c5ea9d6dba81a137ca3f4cef19ec0157f97eae 100644
--- a/build/config/arm.gni
+++ b/build/config/arm.gni
@@ -57,6 +57,9 @@ if (current_cpu == "arm" || v8_current_cpu == "arm") {
if (arm_float_abi == "") {
if (current_os == "android" || target_os == "android") {
jochen (gone - plz use gerrit) 2016/07/25 15:00:32 why not if (current_os == "chromeos" || target_os
Michael Achenbach 2016/07/25 15:17:58 When s/hardfp/hard this should be the same accordi
Dirk Pranke 2016/07/25 17:14:34 I think the current_cpu != v8_current_cpu check sh
arm_float_abi = "softfp"
+ } else if (current_os == "linux" && current_cpu != v8_current_cpu) {
+ # Default to the same as Android for V8 simulator builds.
+ arm_float_abi = "softfp"
} else {
arm_float_abi = "hard"
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698