Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: build/config/arm.gni

Issue 2182473002: gn: Default to softfp for V8 arm simulator builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/v8_target_cpu.gni") 5 import("//build/config/v8_target_cpu.gni")
6 6
7 # These are primarily relevant in current_cpu == "arm" contexts, where 7 # These are primarily relevant in current_cpu == "arm" contexts, where
8 # ARM code is being compiled. But they can also be relevant in the 8 # ARM code is being compiled. But they can also be relevant in the
9 # other contexts when the code will change its behavior based on the 9 # other contexts when the code will change its behavior based on the
10 # cpu it wants to generate code for. 10 # cpu it wants to generate code for.
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 } 48 }
49 arm_fpu = "vfp" 49 arm_fpu = "vfp"
50 arm_use_thumb = false 50 arm_use_thumb = false
51 } else if (arm_version == 7) { 51 } else if (arm_version == 7) {
52 arm_arch = "armv7-a" 52 arm_arch = "armv7-a"
53 if (arm_tune == "") { 53 if (arm_tune == "") {
54 arm_tune = "generic-armv7-a" 54 arm_tune = "generic-armv7-a"
55 } 55 }
56 56
57 if (arm_float_abi == "") { 57 if (arm_float_abi == "") {
58 if (current_os == "android" || target_os == "android") { 58 if (current_os == "android" || target_os == "android") {
jochen (gone - plz use gerrit) 2016/07/25 15:00:32 why not if (current_os == "chromeos" || target_os
Michael Achenbach 2016/07/25 15:17:58 When s/hardfp/hard this should be the same accordi
Dirk Pranke 2016/07/25 17:14:34 I think the current_cpu != v8_current_cpu check sh
59 arm_float_abi = "softfp" 59 arm_float_abi = "softfp"
60 } else if (current_os == "linux" && current_cpu != v8_current_cpu) {
61 # Default to the same as Android for V8 simulator builds.
62 arm_float_abi = "softfp"
60 } else { 63 } else {
61 arm_float_abi = "hard" 64 arm_float_abi = "hard"
62 } 65 }
63 } 66 }
64 67
65 if (arm_use_neon) { 68 if (arm_use_neon) {
66 arm_fpu = "neon" 69 arm_fpu = "neon"
67 } else { 70 } else {
68 arm_fpu = "vfpv3-d16" 71 arm_fpu = "vfpv3-d16"
69 } 72 }
(...skipping 15 matching lines...) Expand all
85 arm_fpu = "neon" 88 arm_fpu = "neon"
86 } else { 89 } else {
87 arm_fpu = "vfpv3-d16" 90 arm_fpu = "vfpv3-d16"
88 } 91 }
89 } 92 }
90 } else if (current_cpu == "arm64" || v8_current_cpu == "arm64") { 93 } else if (current_cpu == "arm64" || v8_current_cpu == "arm64") {
91 # arm64 supports only "hard". 94 # arm64 supports only "hard".
92 arm_float_abi = "hard" 95 arm_float_abi = "hard"
93 arm_use_neon = true 96 arm_use_neon = true
94 } 97 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698