gn: Default to softfp for V8 arm simulator builds

gn: Default to softfp for V8 arm simulator builds

V8 stand-alone arm simulator builds defaulted to softfp in
GYP before.

This prepares to switch v8 arm simulators to GN:
https://codereview.chromium.org/2172193002/

BUG=chromium:474921
Committed: https://crrev.com/bbc92f86178b7f65237bfc19d32caefa11caeba4
Cr-Commit-Position: refs/heads/master@{#407518}

[Michael Achenbach, 2016-07-25 12:40:12]

Description was changed from

==========
gn: Default to softfp for V8 arm simulator builds

BUG=
==========

to

==========
gn: Default to softfp for V8 arm simulator builds

BUG=chromium:474921
==========

[Michael Achenbach, 2016-07-25 12:40:12]

machenbach@chromium.org changed reviewers:
+ dpranke@chromium.org, jochen@chromium.org

[Michael Achenbach, 2016-07-25 12:42:58]

Description was changed from

==========
gn: Default to softfp for V8 arm simulator builds

BUG=chromium:474921
==========

to

==========
gn: Default to softfp for V8 arm simulator builds

V8 stand-alone arm simulator builds defaulted to softfp in
GYP before.

This prepares to switch v8 arm simulators to GN:
https://codereview.chromium.org/2172193002/

BUG=chromium:474921
==========

[Michael Achenbach, 2016-07-25 12:44:12]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 12:44:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-07-25 12:45:23]

PTAL. I don't see an easy way to change the default for v8-standalone only (and
also there's no good reason I think).

[commit-bot: I haz the power, 2016-07-25 13:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 13:42:43]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-07-25 15:00:32]

https://codereview.chromium.org/2182473002/diff/1/build/config/arm.gni
File build/config/arm.gni (right):

https://codereview.chromium.org/2182473002/diff/1/build/config/arm.gni#newcode58
build/config/arm.gni:58: if (current_os == "android" || target_os == "android")
{
why not if (current_os == "chromeos" || target_os == "chromeos") {
 arm_float_abi = "hardfp"
} else {
 arm_float_abi = "softfp"
}

[Michael Achenbach, 2016-07-25 15:17:58]

https://codereview.chromium.org/2182473002/diff/1/build/config/arm.gni
File build/config/arm.gni (right):

https://codereview.chromium.org/2182473002/diff/1/build/config/arm.gni#newcode58
build/config/arm.gni:58: if (current_os == "android" || target_os == "android")
{
On 2016/07/25 15:00:32, jochen wrote:
> why not if (current_os == "chromeos" || target_os == "chromeos") {
>  arm_float_abi = "hardfp"
> } else {
>  arm_float_abi = "softfp"
> }

When s/hardfp/hard this should be the same according to my assumptions. But I
don't trust my assumptions and I wanted to avoid flipping something that
shouldn't be flipped. So the other version is a bit more defensive. What about
linux builds with arm?

Dirk, any thoughts?

[Dirk Pranke, 2016-07-25 17:14:35]

lgtm.

https://codereview.chromium.org/2182473002/diff/1/build/config/arm.gni
File build/config/arm.gni (right):

https://codereview.chromium.org/2182473002/diff/1/build/config/arm.gni#newcode58
build/config/arm.gni:58: if (current_os == "android" || target_os == "android")
{
On 2016/07/25 15:17:58, Michael Achenbach (slow) wrote:
> On 2016/07/25 15:00:32, jochen wrote:
> > why not if (current_os == "chromeos" || target_os == "chromeos") {
> >  arm_float_abi = "hardfp"
> > } else {
> >  arm_float_abi = "softfp"
> > }
> 
> When s/hardfp/hard this should be the same according to my assumptions. But I
> don't trust my assumptions and I wanted to avoid flipping something that
> shouldn't be flipped. So the other version is a bit more defensive. What about
> linux builds with arm?
> 
> Dirk, any thoughts?
> 

I think the current_cpu != v8_current_cpu check should be enough, so this change
should be fine. I'm a little reluctant to have linux not match CrOS by default,
since the main reason we support linux arm is to be closer to CrOS.

[Michael Achenbach, 2016-07-25 18:11:47]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-25 18:12:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 18:16:01]

Description was changed from

==========
gn: Default to softfp for V8 arm simulator builds

V8 stand-alone arm simulator builds defaulted to softfp in
GYP before.

This prepares to switch v8 arm simulators to GN:
https://codereview.chromium.org/2172193002/

BUG=chromium:474921
==========

to

==========
gn: Default to softfp for V8 arm simulator builds

V8 stand-alone arm simulator builds defaulted to softfp in
GYP before.

This prepares to switch v8 arm simulators to GN:
https://codereview.chromium.org/2172193002/

BUG=chromium:474921
==========

[commit-bot: I haz the power, 2016-07-25 18:16:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 18:20:53]

Description was changed from

==========
gn: Default to softfp for V8 arm simulator builds

V8 stand-alone arm simulator builds defaulted to softfp in
GYP before.

This prepares to switch v8 arm simulators to GN:
https://codereview.chromium.org/2172193002/

BUG=chromium:474921
==========

to

==========
gn: Default to softfp for V8 arm simulator builds

V8 stand-alone arm simulator builds defaulted to softfp in
GYP before.

This prepares to switch v8 arm simulators to GN:
https://codereview.chromium.org/2172193002/

BUG=chromium:474921

Committed: https://crrev.com/bbc92f86178b7f65237bfc19d32caefa11caeba4
Cr-Commit-Position: refs/heads/master@{#407518}
==========

[commit-bot: I haz the power, 2016-07-25 18:20:54]

Patchset 1 (id:??) landed as
https://crrev.com/bbc92f86178b7f65237bfc19d32caefa11caeba4
Cr-Commit-Position: refs/heads/master@{#407518}