Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2182453002: [turbofan] Avoid introducing machine operators during typed lowering. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid introducing machine operators during typed lowering. Introducing machine operators early causes trouble for the typing, truncation analysis and representation selection, so we should rather stick to simplified operators instead. Now there's only the for-in case left, which is not clear how we can handle this in a better way. Drive-by-fix: Also don't introduce Int32Constant and Word32Shl in JSTypedLowering, but use NumberConstant and proper NumberShiftLeft operators instead. R=jarin@chromium.org BUG=chromium:630951 Committed: https://crrev.com/5bed1516c8218b2607cbbe9e1f96c8f83376da41 Cr-Commit-Position: refs/heads/master@{#38008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -117 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 8 chunks +60 lines, -85 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-630951.js View 1 chunk +4 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-25 09:52:21 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-25 10:35:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182453002/1
4 years, 5 months ago (2016-07-25 10:35:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 10:37:29 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 10:38:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bed1516c8218b2607cbbe9e1f96c8f83376da41
Cr-Commit-Position: refs/heads/master@{#38008}

Powered by Google App Engine
This is Rietveld 408576698