Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 2182453002: [turbofan] Avoid introducing machine operators during typed lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler/js-intrinsic-lowering-unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index b2b884e53a755cbe623019cb9b8e4aa4bf7121af..8253418519a4d13fb30460bd2a93588a891e84a2 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -619,7 +619,8 @@ TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArray) {
Matcher<Node*> offset_matcher =
element_size == 1
? key
- : IsWord32Shl(key, IsInt32Constant(WhichPowerOf2(element_size)));
+ : IsNumberShiftLeft(key,
+ IsNumberConstant(WhichPowerOf2(element_size)));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
@@ -700,7 +701,8 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArray) {
Matcher<Node*> offset_matcher =
element_size == 1
? key
- : IsWord32Shl(key, IsInt32Constant(WhichPowerOf2(element_size)));
+ : IsNumberShiftLeft(
+ key, IsNumberConstant(WhichPowerOf2(element_size)));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
@@ -747,7 +749,8 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {
Matcher<Node*> offset_matcher =
element_size == 1
? key
- : IsWord32Shl(key, IsInt32Constant(WhichPowerOf2(element_size)));
+ : IsNumberShiftLeft(
+ key, IsNumberConstant(WhichPowerOf2(element_size)));
Matcher<Node*> value_matcher =
IsToNumber(value, context, checkpoint, control);
« no previous file with comments | « test/unittests/compiler/js-intrinsic-lowering-unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698