Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2182413005: Merge "Add more UseCounters for -webkit-appearance:button and -webkit-appearance:textfield." to M53. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge "Add more UseCounters for -webkit-appearance:button and -webkit-appearance:textfield." to M53. We found - |button| and |textfield| were frequently used in 'CSS reset' - there were some instances of <a> with -webkit-appearance:button We'd like to know how frequently they affect actual rendering. This CL adds the following counters: * -webkit-appearance:button is actually rendered * -webkit-appearance:button for elements with button appearance by default * -webkit-appearance:button for <a> * -webkit-appearance:button for element with push-button appearance by default * -webkit-appearance:textfield is actually rendered * -webkit-appearance:textfield for elements with textfield appearance by default * -webkit-appearance:textfield for <input type=search> BUG=631849 Review-Url: https://codereview.chromium.org/2177283008 Cr-Commit-Position: refs/heads/master@{#408033} (cherry picked from commit 7b592f6c3a2c7a8caa92412b72192ddacee01341) Committed: https://chromium.googlesource.com/chromium/src/+/f262617ee9532463277cac7a39d4b30af6b164e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 3 chunks +22 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 4 months ago (2016-07-28 04:21:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f262617ee9532463277cac7a39d4b30af6b164e1.

Powered by Google App Engine
This is Rietveld 408576698