Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2177283008: Add more UseCounters for -webkit-appearance:button and -webkit-appearance:textfield. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
keishi, Ilya Sherman
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more UseCounters for -webkit-appearance:button and -webkit-appearance:textfield. We found - |button| and |textfield| were frequently used in 'CSS reset' - there were some instances of <a> with -webkit-appearance:button We'd like to know how frequently they affect actual rendering. This CL adds the following counters: * -webkit-appearance:button is actually rendered * -webkit-appearance:button for elements with button appearance by default * -webkit-appearance:button for <a> * -webkit-appearance:button for element with push-button appearance by default * -webkit-appearance:textfield is actually rendered * -webkit-appearance:textfield for elements with textfield appearance by default * -webkit-appearance:textfield for <input type=search> BUG=631849 Committed: https://crrev.com/7b592f6c3a2c7a8caa92412b72192ddacee01341 Cr-Commit-Position: refs/heads/master@{#408033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 3 chunks +22 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
tkent
keishi@, would you review this please? isherman@, would you approve histograms.xml please?
4 years, 4 months ago (2016-07-27 01:59:10 UTC) #7
keishi
LGTM
4 years, 4 months ago (2016-07-27 02:06:27 UTC) #8
Ilya Sherman
histograms.xml lgtm
4 years, 4 months ago (2016-07-27 02:15:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177283008/1
4 years, 4 months ago (2016-07-27 03:20:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 03:26:49 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 03:30:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b592f6c3a2c7a8caa92412b72192ddacee01341
Cr-Commit-Position: refs/heads/master@{#408033}

Powered by Google App Engine
This is Rietveld 408576698