Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py

Issue 2182413004: In rietveld.filter_latest_jobs, handle jobs with no build number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update pylintrc to just apply to test_ methods Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
index 9a6fca283f1ca161464b4c944d7f85ce8408e5bf..494f7481e782c799e3550c26f074c3e261400b06 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
@@ -98,24 +98,15 @@ class RietveldTest(unittest.TestCase):
def test_filter_latest_jobs_higher_build_first(self):
self.assertEqual(
- filter_latest_jobs([
- Build('foo', 5),
- Build('foo', 3),
- Build('bar', 5),
- ]),
- [
- Build('foo', 5),
- Build('bar', 5),
- ])
+ filter_latest_jobs([Build('foo', 5), Build('foo', 3), Build('bar', 5)]),
+ [Build('foo', 5), Build('bar', 5)])
def test_filter_latest_jobs_higher_build_last(self):
self.assertEqual(
- filter_latest_jobs([
- Build('foo', 3),
- Build('bar', 5),
- Build('foo', 5),
- ]),
- [
- Build('bar', 5),
- Build('foo', 5),
- ])
+ filter_latest_jobs([Build('foo', 3), Build('bar', 5), Build('foo', 5)]),
+ [Build('bar', 5), Build('foo', 5)])
+
+ def test_filter_latest_jobs_no_build_number(self):
+ self.assertEqual(
+ filter_latest_jobs([Build('foo', 3), Build('bar')]),
+ [Build('foo', 3)])

Powered by Google App Engine
This is Rietveld 408576698