third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py - Issue 2182413004: In rietveld.filter_latest_jobs, handle jobs with no build number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

Issue 2182413004: In rietveld.filter_latest_jobs, handle jobs with no build number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update pylintrc to just apply to test_ methods Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/pylintrc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

index 9d276cc98237bfa746e0f423ca0bc006a851abf7..ffb904a24fc1b7e1835f34dfaf193bed1aeb135f 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

@@ -96,7 +96,10 @@ def filter_latest_jobs(jobs):

for j in jobs:

if j.build_number > builder_to_highest_number.get(j.builder_name, 0):

builder_to_highest_number[j.builder_name] = j.build_number

- return [j for j in jobs if builder_to_highest_number[j.builder_name] == j.build_number]

+ return [j for j in jobs if (

+ j.builder_name in builder_to_highest_number and

+ builder_to_highest_number[j.builder_name] == j.build_number

+ )]

def get_latest_try_job_results(issue_number, web):