Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2182273002: SW backend for viewer on Windows (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -13 lines) Patch
M tools/viewer/sk_app/GLWindowContext.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/GLWindowContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/Window.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/Window.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/WindowContext.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/android/RasterWindowContext_android.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/unix/RasterWindowContext_unix.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
A tools/viewer/sk_app/win/RasterWindowContext_win.cpp View 1 1 chunk +96 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/win/WindowContextFactory_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/win/Window_win.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
4 years, 4 months ago (2016-07-26 21:21:07 UTC) #3
jvanverth1
Have you built this on Linux or Mac? There might be some pickiness about the ...
4 years, 4 months ago (2016-07-27 13:40:25 UTC) #4
bsalomon
On 2016/07/27 13:40:25, jvanverth1 wrote: > Have you built this on Linux or Mac? There ...
4 years, 4 months ago (2016-07-27 14:10:21 UTC) #5
jvanverth1
I seem to remember there was a reason I picked unsigned rather than int for ...
4 years, 4 months ago (2016-07-27 14:42:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182273002/20001
4 years, 4 months ago (2016-07-27 14:48:15 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 15:50:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ccde4ab8e6f5d9f0634d7f156dc1617fd0e48581

Powered by Google App Engine
This is Rietveld 408576698