Remove BitmapPlatformDevice from NativeThemeWin

skia/ext/skia_utils_win.h

Index: skia/ext/skia_utils_win.h
diff --git a/skia/ext/skia_utils_win.h b/skia/ext/skia_utils_win.h
index bfcbf2619b247810082e5a14b547a7c6289e92af..4ec29e81341707c09d103c98f5cc32cbd1f38a7a 100644
--- a/skia/ext/skia_utils_win.h
+++ b/skia/ext/skia_utils_win.h
@@ -5,8 +5,10 @@
 #ifndef SKIA_EXT_SKIA_UTILS_WIN_H_
 #define SKIA_EXT_SKIA_UTILS_WIN_H_
 
+#include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "third_party/skia/include/core/SkMatrix.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
 
 #include "build/build_config.h"
 #include <windows.h>
@@ -14,6 +16,7 @@
 struct SkIRect;
 struct SkPoint;
 struct SkRect;
+class SkSurface;
 typedef unsigned long DWORD;
 typedef DWORD COLORREF;
 typedef struct tagPOINT POINT;
@@ -60,6 +63,19 @@ SK_API void LoadTransformToDC(HDC dc, const SkMatrix& matrix);
 SK_API void CopyHDC(HDC source, HDC destination, int x, int y, bool is_opaque,
                     const RECT& src_rect, const SkMatrix& transform);
 
+// Creates a surface writing to the pixels backing the HDC's bitmap.

[Peter Kasting, 2016/08/03 01:40:25]

Tiny nit: I would say "|context|'s" rather than "the HDC's" here and below, just
to be clear you don't mean some other global HDC or something.

[tomhudson, 2016/08/03 12:55:03]

Done.

+// Returns nullptr on error.

[Peter Kasting, 2016/08/03 01:40:25]

Nit: I think we typically just say "null" in comments rather than "nullptr",
though I don't know that that holds globally or is documented anywhere.

[tomhudson, 2016/08/03 12:55:03]

Done.

+SK_API sk_sp<SkSurface> MapPlatformSurface(HDC context);
+
+// Creates a bitmap backed by the same pixels backing the HDC's bitmap.
+// Returns an empty bitmap on error.
+SK_API SkBitmap MapPlatformBitmap(HDC context);
+
+// Creates an offscreen HDC suitable for writing to via MapPlatformSurface().
+// Caller is responsible for calling DeleteDC() when done.
+// Will return null if any errors are encountered.
+SK_API HDC CreateOffscreenSurface(int width, int height);

[Peter Kasting, 2016/08/03 01:40:25]

Nit: Might want a "TODO(tomhudson): Return a ScopedCreateDC instead, once that
type is returnable.  See https://crbug.com/622442 .

Nit: Can this take a gfx::Size instead of width and height?

[tomhudson, 2016/08/03 12:55:03]

TODO(fmalita) for now.
That inverts the direction of dependency. I know crbug.com/13714 still argues we
should fold all of skia/ext into gfx, but until we do, this code isn't supposed
to depend on anything in gfx, and as far as I can tell only does so within
unittests.

+
 // Fills in a BITMAPINFOHEADER structure given the bitmap's size.
 SK_API void CreateBitmapHeader(int width, int height, BITMAPINFOHEADER* hdr);