Remove BitmapPlatformDevice from NativeThemeWin

skia/ext/skia_utils_win.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SKIA_EXT_SKIA_UTILS_WIN_H_
 #define SKIA_EXT_SKIA_UTILS_WIN_H_
 
+#include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "third_party/skia/include/core/SkMatrix.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
 
 #include "build/build_config.h"
 #include <windows.h>
 
 struct SkIRect;
 struct SkPoint;
 struct SkRect;
+class SkSurface;
 typedef unsigned long DWORD;
 typedef DWORD COLORREF;
 typedef struct tagPOINT POINT;
 typedef struct tagRECT RECT;
 
 namespace skia {
 
 // Converts a Skia point to a Windows POINT.
 POINT SkPointToPOINT(const SkPoint& point);
 
@@ skipping 26 matching lines @@
 // Converts scale, skew, and translation to Windows format and sets it on the
 // HDC.
 SK_API void LoadTransformToDC(HDC dc, const SkMatrix& matrix);
 
 // Copies |src_rect| from source into destination.
 //   Takes a potentially-slower path if |is_opaque| is false.
 //   Sets |transform| on source afterwards!
 SK_API void CopyHDC(HDC source, HDC destination, int x, int y, bool is_opaque,
                     const RECT& src_rect, const SkMatrix& transform);
 
+// Creates a surface writing to the pixels backing the HDC's bitmap.

[Peter Kasting, 2016/08/03 01:40:25]

Tiny nit: I would say "|context|'s" rather than "the HDC's" here and below, just
to be clear you don't mean some other global HDC or something.

[tomhudson, 2016/08/03 12:55:03]

Done.

+// Returns nullptr on error.

[Peter Kasting, 2016/08/03 01:40:25]

Nit: I think we typically just say "null" in comments rather than "nullptr",
though I don't know that that holds globally or is documented anywhere.

[tomhudson, 2016/08/03 12:55:03]

Done.

+SK_API sk_sp<SkSurface> MapPlatformSurface(HDC context);
+
+// Creates a bitmap backed by the same pixels backing the HDC's bitmap.
+// Returns an empty bitmap on error.
+SK_API SkBitmap MapPlatformBitmap(HDC context);
+
+// Creates an offscreen HDC suitable for writing to via MapPlatformSurface().
+// Caller is responsible for calling DeleteDC() when done.
+// Will return null if any errors are encountered.
+SK_API HDC CreateOffscreenSurface(int width, int height);

[Peter Kasting, 2016/08/03 01:40:25]

Nit: Might want a "TODO(tomhudson): Return a ScopedCreateDC instead, once that
type is returnable.  See https://crbug.com/622442 .

Nit: Can this take a gfx::Size instead of width and height?

[tomhudson, 2016/08/03 12:55:03]

TODO(fmalita) for now.
That inverts the direction of dependency. I know crbug.com/13714 still argues we
should fold all of skia/ext into gfx, but until we do, this code isn't supposed
to depend on anything in gfx, and as far as I can tell only does so within
unittests.

+
 // Fills in a BITMAPINFOHEADER structure given the bitmap's size.
 SK_API void CreateBitmapHeader(int width, int height, BITMAPINFOHEADER* hdr);
 
 SK_API HBITMAP CreateHBitmap(int width, int height, bool is_opaque,
                              HANDLE shared_section = nullptr,
                              void** data = nullptr);
 
 }  // namespace skia
 
 #endif  // SKIA_EXT_SKIA_UTILS_WIN_H_