third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Added underlying type notes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index 42a76bc6d31bfe668fed3c7ff1a3ba071bd30424..b158172674f26a8d09a18bf9868761ee8a669898 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -1050,7 +1050,7 @@ LayoutRect LayoutInline::localOverflowRectForPaintInvalidation() const

if (!alwaysCreateLineBoxes())

return LayoutRect();

- if (style()->visibility() != VISIBLE)

+ if (style()->visibility() != EVisibility::Visible)

return LayoutRect();

return visualOverflowRect();

@@ -1336,7 +1336,7 @@ void LayoutInline::computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layo

void LayoutInline::addAnnotatedRegions(Vector<AnnotatedRegionValue>& regions)

{

// Convert the style regions to absolute coordinates.

- if (style()->visibility() != VISIBLE)

+ if (style()->visibility() != EVisibility::Visible)

return;

if (style()->getDraggableRegionMode() == DraggableRegionNone)