Changed ComputedStyle's EVisibility to be an enum class and fixed naming

third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Index: third_party/WebKit/Source/core/style/ComputedStyleConstants.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
index f9b57ee99066caf889ba7235ec1d5ffe5917b305..31d3040d7c9bb1c30f0ffb80e56d559a2511c1b9 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
@@ -30,6 +30,11 @@
 
 namespace blink {
 
+// TODO(sashab): Change these enums to enum classes with an unsigned underlying
+// type. Enum classes provide better type safety, and forcing an unsigned
+// underlying type prevents msvc from interpreting enums as negative numbers.
+// See: crbug.com/628043
+
 // Sides used when drawing borders and outlines. The values should run clockwise from top.
 enum BoxSide {
     BSTop,
@@ -386,7 +391,7 @@ enum ECaptionSide {
 
 enum EListStylePosition { ListStylePositionOutside, ListStylePositionInside };
 
-enum EVisibility { VISIBLE, HIDDEN, COLLAPSE };
+enum class EVisibility : unsigned { Visible, Hidden, Collapse };

[esprehn, 2016/08/02 02:37:44]

Do the static_asserts for size fail if you leave off the unsigned? :)

[sashab, 2016/08/02 06:02:39]

No, ComputedStyle does have a style check but from other experiments this no
longer seems to be a problem.

Added a TODO anyway, I still want to check that this is unsigned, lots of ways
to do this so I think we should leave this for another patch. :)

 
 enum ECursor {
     // The following must match the order in CSSValueKeywords.in.