third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

index 0ddebf88ca874e9acf8d9d282a3e886148d23f68..cd7b9097f0ca9f0808f94568b9d65ad8bf5b2a12 100644

--- a/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp

@@ -156,10 +156,10 @@ void SimplifiedBackwardsTextIteratorAlgorithm<Strategy>::advance()

LayoutObject* layoutObject = m_node->layoutObject();

if (layoutObject && layoutObject->isText() && m_node->getNodeType() == Node::TEXT_NODE) {

// FIXME: What about CDATA_SECTION_NODE?

- if (layoutObject->style()->visibility() == VISIBLE && m_offset > 0)

+ if (layoutObject->style()->visibility() == EVisibility::Visible && m_offset > 0)

m_handledNode = handleTextNode();

} else if (layoutObject && (layoutObject->isLayoutPart() || TextIterator::supportsAltText(m_node))) {

- if (layoutObject->style()->visibility() == VISIBLE && m_offset > 0)

+ if (layoutObject->style()->visibility() == EVisibility::Visible && m_offset > 0)

m_handledNode = handleReplacedElement();

} else {

m_handledNode = handleNonTextNode();