Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 397bfe19929fa471299c323165ed1d8d7bea35ae..390a4498d089561b46de096c0b52c72a87ba23cd 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -1511,7 +1511,7 @@ PositionTemplate<Strategy> startOfParagraphAlgorithm(const PositionTemplate<Stra
continue;
}
const ComputedStyle& style = layoutItem.styleRef();
- if (style.visibility() != VISIBLE) {
+ if (style.visibility() != EVisibility::Visible) {
prevousNodeIterator = Strategy::previousPostOrder(*prevousNodeIterator, startBlock);
continue;
}
@@ -1602,7 +1602,7 @@ static PositionTemplate<Strategy> endOfParagraphAlgorithm(const PositionTemplate
continue;
}
const ComputedStyle& style = layoutObject->styleRef();
- if (style.visibility() != VISIBLE) {
+ if (style.visibility() != EVisibility::Visible) {
nextNodeItreator = Strategy::next(*nextNodeItreator, startBlock);
continue;
}
@@ -2397,7 +2397,7 @@ static PositionTemplate<Strategy> mostBackwardCaretPosition(const PositionTempla
// skip position in non-laid out or invisible node
LayoutObject* layoutObject = associatedLayoutObjectOf(*currentNode, currentPos.offsetInLeafNode());
- if (!layoutObject || layoutObject->style()->visibility() != VISIBLE)
+ if (!layoutObject || layoutObject->style()->visibility() != EVisibility::Visible)
continue;
if (rule == CanCrossEditingBoundary && boundaryCrossed) {
@@ -2445,7 +2445,7 @@ static PositionTemplate<Strategy> mostBackwardCaretPosition(const PositionTempla
// |Text| node with :first-letter.
DCHECK_GE(currentPos.offsetInLeafNode(), 1);
LayoutObject* firstLetterLayoutObject = toLayoutTextFragment(layoutObject)->firstLetterPseudoElement()->layoutObject();
- if (firstLetterLayoutObject && firstLetterLayoutObject->style()->visibility() == VISIBLE)
+ if (firstLetterLayoutObject && firstLetterLayoutObject->style()->visibility() == EVisibility::Visible)
return currentPos.computePosition();
}
continue;
@@ -2548,7 +2548,7 @@ PositionTemplate<Strategy> mostForwardCaretPosition(const PositionTemplate<Strat
// skip position in non-laid out or invisible node
LayoutObject* layoutObject = associatedLayoutObjectOf(*currentNode, currentPos.offsetInLeafNode());
- if (!layoutObject || layoutObject->style()->visibility() != VISIBLE)
+ if (!layoutObject || layoutObject->style()->visibility() != EVisibility::Visible)
continue;
if (rule == CanCrossEditingBoundary && boundaryCrossed) {
@@ -2666,7 +2666,7 @@ static bool isVisuallyEquivalentCandidateAlgorithm(const PositionTemplate<Strate
if (!layoutObject)
return false;
- if (layoutObject->style()->visibility() != VISIBLE)
+ if (layoutObject->style()->visibility() != EVisibility::Visible)
return false;
if (layoutObject->isBR()) {

Powered by Google App Engine
This is Rietveld 408576698