Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: net/quic/quic_flow_controller_test.cc

Issue 2181813002: deprecate FLAGS_quic_auto_tune_receive_window, FLAGS_quic_enable_autotune_by_defau… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128178269
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flow_controller.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_flow_controller_test.cc
diff --git a/net/quic/quic_flow_controller_test.cc b/net/quic/quic_flow_controller_test.cc
index 275af53e1f1d3f1e31fdceb1bddd94c1bdd04915..d2e040b421c8de930c48abf986ce254f9ca1a327 100644
--- a/net/quic/quic_flow_controller_test.cc
+++ b/net/quic/quic_flow_controller_test.cc
@@ -156,7 +156,6 @@ TEST_F(QuicFlowControllerTest, OnlySendBlockedFrameOncePerOffset) {
}
TEST_F(QuicFlowControllerTest, ReceivingBytesFastIncreasesFlowWindow) {
- FLAGS_quic_auto_tune_receive_window = true;
// This test will generate two WINDOW_UPDATE frames.
EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
@@ -209,13 +208,12 @@ TEST_F(QuicFlowControllerTest, ReceivingBytesFastIncreasesFlowWindow) {
EXPECT_GT(new_threshold, threshold);
}
-TEST_F(QuicFlowControllerTest, ReceivingBytesFastStatusQuo) {
- FLAGS_quic_auto_tune_receive_window = false;
+TEST_F(QuicFlowControllerTest, ReceivingBytesFastNoAutoTune) {
// This test will generate two WINDOW_UPDATE frames.
EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
Initialize();
- flow_controller_->set_auto_tune_receive_window(true);
+ flow_controller_->set_auto_tune_receive_window(false);
// Make sure clock is inititialized.
connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
@@ -264,7 +262,6 @@ TEST_F(QuicFlowControllerTest, ReceivingBytesFastStatusQuo) {
}
TEST_F(QuicFlowControllerTest, ReceivingBytesNormalStableFlowWindow) {
- FLAGS_quic_auto_tune_receive_window = true;
// This test will generate two WINDOW_UPDATE frames.
EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
@@ -319,13 +316,12 @@ TEST_F(QuicFlowControllerTest, ReceivingBytesNormalStableFlowWindow) {
EXPECT_EQ(new_threshold, threshold);
}
-TEST_F(QuicFlowControllerTest, ReceivingBytesNormalStatusQuo) {
- FLAGS_quic_auto_tune_receive_window = false;
+TEST_F(QuicFlowControllerTest, ReceivingBytesNormalNoAutoTune) {
// This test will generate two WINDOW_UPDATE frames.
EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
Initialize();
- flow_controller_->set_auto_tune_receive_window(true);
+ flow_controller_->set_auto_tune_receive_window(false);
// Make sure clock is inititialized.
connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
« no previous file with comments | « net/quic/quic_flow_controller.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698