deprecate FLAGS_quic_auto_tune_receive_window, FLAGS_quic_enable_autotune_by_defau…

net/quic/quic_flow_controller_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_flow_controller.h"
 
 #include <memory>
 
 #include "base/format_macros.h"
 #include "base/strings/stringprintf.h"
@@ skipping 138 matching lines @@
   EXPECT_EQ(send_window_, flow_controller_->SendWindowSize());
   flow_controller_->AddBytesSent(send_window_);
   EXPECT_TRUE(flow_controller_->IsBlocked());
   EXPECT_EQ(0u, flow_controller_->SendWindowSize());
 
   // BLOCKED frame should get sent as send offset has changed.
   flow_controller_->MaybeSendBlocked();
 }
 
 TEST_F(QuicFlowControllerTest, ReceivingBytesFastIncreasesFlowWindow) {
-  FLAGS_quic_auto_tune_receive_window = true;
   // This test will generate two WINDOW_UPDATE frames.
   EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
 
   Initialize();
   flow_controller_->set_auto_tune_receive_window(true);
 
   // Make sure clock is inititialized.
   connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
 
   QuicSentPacketManagerInterface* manager =
@@ skipping 32 matching lines @@
   connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(2 * kRtt - 1));
   receive_offset += threshold + 1;
   EXPECT_TRUE(flow_controller_->UpdateHighestReceivedOffset(receive_offset));
   flow_controller_->AddBytesConsumed(threshold + 1);
   EXPECT_FALSE(flow_controller_->FlowControlViolation());
   QuicByteCount new_threshold =
       QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
   EXPECT_GT(new_threshold, threshold);
 }
 
-TEST_F(QuicFlowControllerTest, ReceivingBytesFastStatusQuo) {
-  FLAGS_quic_auto_tune_receive_window = false;
+TEST_F(QuicFlowControllerTest, ReceivingBytesFastNoAutoTune) {
   // This test will generate two WINDOW_UPDATE frames.
   EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
 
   Initialize();
-  flow_controller_->set_auto_tune_receive_window(true);
+  flow_controller_->set_auto_tune_receive_window(false);
 
   // Make sure clock is inititialized.
   connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
 
   QuicSentPacketManagerInterface* manager =
       QuicConnectionPeer::GetSentPacketManager(&connection_, kDefaultPathId);
 
   RttStats* rtt_stats = const_cast<RttStats*>(manager->GetRttStats());
   rtt_stats->UpdateRtt(QuicTime::Delta::FromMilliseconds(kRtt),
                        QuicTime::Delta::Zero(), QuicTime::Zero());
@@ skipping 28 matching lines @@
   receive_offset += threshold + 1;
   EXPECT_TRUE(flow_controller_->UpdateHighestReceivedOffset(receive_offset));
   flow_controller_->AddBytesConsumed(threshold + 1);
   EXPECT_FALSE(flow_controller_->FlowControlViolation());
   QuicByteCount new_threshold =
       QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
   EXPECT_EQ(new_threshold, threshold);
 }
 
 TEST_F(QuicFlowControllerTest, ReceivingBytesNormalStableFlowWindow) {
-  FLAGS_quic_auto_tune_receive_window = true;
   // This test will generate two WINDOW_UPDATE frames.
   EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
 
   Initialize();
   flow_controller_->set_auto_tune_receive_window(true);
 
   // Make sure clock is inititialized.
   connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
 
   QuicSentPacketManagerInterface* manager =
@@ skipping 34 matching lines @@
 
   flow_controller_->AddBytesConsumed(threshold + 1);
   EXPECT_FALSE(flow_controller_->FlowControlViolation());
 
   QuicByteCount new_threshold =
       QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
 
   EXPECT_EQ(new_threshold, threshold);
 }
 
-TEST_F(QuicFlowControllerTest, ReceivingBytesNormalStatusQuo) {
-  FLAGS_quic_auto_tune_receive_window = false;
+TEST_F(QuicFlowControllerTest, ReceivingBytesNormalNoAutoTune) {
   // This test will generate two WINDOW_UPDATE frames.
   EXPECT_CALL(connection_, SendWindowUpdate(stream_id_, ::testing::_)).Times(2);
 
   Initialize();
-  flow_controller_->set_auto_tune_receive_window(true);
+  flow_controller_->set_auto_tune_receive_window(false);
 
   // Make sure clock is inititialized.
   connection_.AdvanceTime(QuicTime::Delta::FromMilliseconds(1));
 
   QuicSentPacketManagerInterface* manager =
       QuicConnectionPeer::GetSentPacketManager(&connection_, kDefaultPathId);
   RttStats* rtt_stats = const_cast<RttStats*>(manager->GetRttStats());
   rtt_stats->UpdateRtt(QuicTime::Delta::FromMilliseconds(kRtt),
                        QuicTime::Delta::Zero(), QuicTime::Zero());
 
@@ skipping 31 matching lines @@
   EXPECT_FALSE(flow_controller_->FlowControlViolation());
 
   QuicByteCount new_threshold =
       QuicFlowControllerPeer::WindowUpdateThreshold(flow_controller_.get());
 
   EXPECT_EQ(new_threshold, threshold);
 }
 
 }  // namespace test
 }  // namespace net