Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2181793002:
Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSan… (Closed)
DescriptionAdd rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test.
Recent changes to chrome_elf to integrate with crashpad for crash
reporting have brought in dependencies on base which pull in UuidCreate
from rpcrt4. This code path is not exercised in chrome_elf which delay
loads rpcrt4.
I also verified that rpcrt4 does not internally pull in user32
Additionally I removed the list of dlls under COMPONENT_BUILD for this test as it does not run in this mode.
BUG=630744
Committed: https://crrev.com/101ccf53ead99297f70681fff4e7e469dcabc542
Cr-Commit-Position: refs/heads/master@{#407989}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 22 (12 generated)
ananta@chromium.org changed reviewers: + robertshield@google.com
The CQ bit was checked by ananta@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ananta@chromium.org
krasin@google.com changed reviewers: + krasin@google.com
https://codereview.chromium.org/2181793002/diff/1/chrome_elf/elf_imports_unit... File chrome_elf/elf_imports_unittest.cc (left): https://codereview.chromium.org/2181793002/diff/1/chrome_elf/elf_imports_unit... chrome_elf/elf_imports_unittest.cc:80: #if defined(COMPONENT_BUILD) This change should probably be reflected in the CL description (if intended)
Description was changed from ========== Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test. Recent changes to chrome_elf to integrate with crashpad for crash reporting have brought in dependencies on base which pull in UuidCreate from rpcrt4. This code path is not exercised in chrome_elf which delay loads rpcrt4. I also verified that rpcrt4 does not internally pull in user32 BUG=630744 ========== to ========== Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test. Recent changes to chrome_elf to integrate with crashpad for crash reporting have brought in dependencies on base which pull in UuidCreate from rpcrt4. This code path is not exercised in chrome_elf which delay loads rpcrt4. I also verified that rpcrt4 does not internally pull in user32 Additionally I removed the list of dlls under COMPONENT_BUILD for this test as it does not run in this mode. BUG=630744 ==========
https://codereview.chromium.org/2181793002/diff/1/chrome_elf/elf_imports_unit... File chrome_elf/elf_imports_unittest.cc (left): https://codereview.chromium.org/2181793002/diff/1/chrome_elf/elf_imports_unit... chrome_elf/elf_imports_unittest.cc:80: #if defined(COMPONENT_BUILD) On 2016/07/25 21:10:06, krasin wrote: > This change should probably be reflected in the CL description (if intended) Done.
Thank you. LGTM
On 2016/07/25 21:12:45, krasin wrote: > Thank you. LGTM Ah, I guess you will still need to get an approval from Robert for the OWNERS check.
robertshield@chromium.org changed reviewers: + robertshield@chromium.org
LGTM. I checked on Win10, if you have a VM or an old Windows version handy, could you double check that rpcrt4.dll doesn't depend on user32.dll on Win7 as well?
On 2016/07/26 04:27:06, robertshield wrote: > LGTM. I checked on Win10, if you have a VM or an old Windows version handy, > could you double check that rpcrt4.dll doesn't depend on user32.dll on Win7 as > well? Checked on Windows 7 and 8.1
The CQ bit was checked by ananta@chromium.org
The CQ bit was unchecked by ananta@chromium.org
The CQ bit was checked by ananta@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test. Recent changes to chrome_elf to integrate with crashpad for crash reporting have brought in dependencies on base which pull in UuidCreate from rpcrt4. This code path is not exercised in chrome_elf which delay loads rpcrt4. I also verified that rpcrt4 does not internally pull in user32 Additionally I removed the list of dlls under COMPONENT_BUILD for this test as it does not run in this mode. BUG=630744 ========== to ========== Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test. Recent changes to chrome_elf to integrate with crashpad for crash reporting have brought in dependencies on base which pull in UuidCreate from rpcrt4. This code path is not exercised in chrome_elf which delay loads rpcrt4. I also verified that rpcrt4 does not internally pull in user32 Additionally I removed the list of dlls under COMPONENT_BUILD for this test as it does not run in this mode. BUG=630744 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test. Recent changes to chrome_elf to integrate with crashpad for crash reporting have brought in dependencies on base which pull in UuidCreate from rpcrt4. This code path is not exercised in chrome_elf which delay loads rpcrt4. I also verified that rpcrt4 does not internally pull in user32 Additionally I removed the list of dlls under COMPONENT_BUILD for this test as it does not run in this mode. BUG=630744 ========== to ========== Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSanityCheck test. Recent changes to chrome_elf to integrate with crashpad for crash reporting have brought in dependencies on base which pull in UuidCreate from rpcrt4. This code path is not exercised in chrome_elf which delay loads rpcrt4. I also verified that rpcrt4 does not internally pull in user32 Additionally I removed the list of dlls under COMPONENT_BUILD for this test as it does not run in this mode. BUG=630744 Committed: https://crrev.com/101ccf53ead99297f70681fff4e7e469dcabc542 Cr-Commit-Position: refs/heads/master@{#407989} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/101ccf53ead99297f70681fff4e7e469dcabc542 Cr-Commit-Position: refs/heads/master@{#407989} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
