chrome_elf/elf_imports_unittest.cc - Issue 2181793002: Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSan…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/elf_imports_unittest.cc

Issue 2181793002: Add rpcrt4.dll to the list of allowed imports for chrome_elf.dll in the ELFImportsTest.ChromeElfSan… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/elf_imports_unittest.cc

diff --git a/chrome_elf/elf_imports_unittest.cc b/chrome_elf/elf_imports_unittest.cc

index 016398965ddb10a404efe5668d3e464a24c725e2..1e399ae83fd335cba82f62c980bfb5f41286c0e1 100644

--- a/chrome_elf/elf_imports_unittest.cc

+++ b/chrome_elf/elf_imports_unittest.cc

@@ -77,11 +77,7 @@ TEST_F(ELFImportsTest, ChromeElfSanityCheck) {

static const char* const kValidFilePatterns[] = {

"KERNEL32.dll",

-#if defined(COMPONENT_BUILD)

krasin 2016/07/25 21:10:06 This change should probably be reflected in the CL

ananta 2016/07/25 21:11:42 Done.

- "MSVC*.dll",

- "VCRUNTIME*.dll",

- "api-ms-win-crt-*.dll",

-#endif

+ "RPCRT4.dll",

#if defined(SYZYASAN)

"syzyasan_rtl.dll",

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »