Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: content/common/page_state_serialization_unittest.cc

Issue 2181753002: Simplify EncodePageState to return no value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/page_state_serialization.cc ('k') | content/public/common/page_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/page_state_serialization_unittest.cc
diff --git a/content/common/page_state_serialization_unittest.cc b/content/common/page_state_serialization_unittest.cc
index 99039f2a7f76ca7f2c012fe6564df0c30572dec7..9ed9d33ed044325f3e5933dcef7077ca9c8c07ea 100644
--- a/content/common/page_state_serialization_unittest.cc
+++ b/content/common/page_state_serialization_unittest.cc
@@ -241,7 +241,7 @@ TEST_F(PageStateSerializationTest, BasicEmpty) {
ExplodedPageState input;
std::string encoded;
- EXPECT_TRUE(EncodePageState(input, &encoded));
+ EncodePageState(input, &encoded);
ExplodedPageState output;
EXPECT_TRUE(DecodePageState(encoded, &output));
@@ -254,7 +254,7 @@ TEST_F(PageStateSerializationTest, BasicFrame) {
PopulateFrameState(&input.top);
std::string encoded;
- EXPECT_TRUE(EncodePageState(input, &encoded));
+ EncodePageState(input, &encoded);
ExplodedPageState output;
EXPECT_TRUE(DecodePageState(encoded, &output));
@@ -268,7 +268,7 @@ TEST_F(PageStateSerializationTest, BasicFramePOST) {
PopulateHttpBody(&input.top.http_body, &input.referenced_files);
std::string encoded;
- EXPECT_TRUE(EncodePageState(input, &encoded));
+ EncodePageState(input, &encoded);
ExplodedPageState output;
EXPECT_TRUE(DecodePageState(encoded, &output));
@@ -288,7 +288,7 @@ TEST_F(PageStateSerializationTest, BasicFrameSet) {
}
std::string encoded;
- EXPECT_TRUE(EncodePageState(input, &encoded));
+ EncodePageState(input, &encoded);
ExplodedPageState output;
EXPECT_TRUE(DecodePageState(encoded, &output));
@@ -371,7 +371,7 @@ TEST_F(PageStateSerializationTest, DumpExpectedPageStateForBackwardsCompat) {
PopulatePageStateForBackwardsCompatTest(&state);
std::string encoded;
- EXPECT_TRUE(EncodePageState(state, &encoded));
+ EncodePageState(state, &encoded);
std::string base64;
base::Base64Encode(encoded, &base64);
« no previous file with comments | « content/common/page_state_serialization.cc ('k') | content/public/common/page_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698