content/public/common/page_state.cc - Issue 2181753002: Simplify EncodePageState to return no value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/page_state.cc

Issue 2181753002: Simplify EncodePageState to return no value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/page_state.cc

diff --git a/content/public/common/page_state.cc b/content/public/common/page_state.cc

index b082d54c91d548b4d6b77f81a458f3c23a887a5a..01cbedbedb7a394d39a81aa9d5b06f832c593259 100644

--- a/content/public/common/page_state.cc

+++ b/content/public/common/page_state.cc

@@ -32,9 +32,7 @@ void ToFilePathVector(const std::vector<base::NullableString16>& input,

PageState ToPageState(const ExplodedPageState& state) {

std::string encoded_data;

- if (!EncodePageState(state, &encoded_data))

- return PageState();

+ EncodePageState(state, &encoded_data);

return PageState::CreateFromEncodedData(encoded_data);

}