Simplify EncodePageState to return no value.

Simplify EncodePageState to return no value.

It was never able to return false, which led to unnecessary error
case handling.  Removing the return value makes reasoning about
invalid PageStates easier.

BUG=568703
TEST=No behavior change.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/20ada69560e72b05b08787483c442addf37624ee
Cr-Commit-Position: refs/heads/master@{#407552}

[Charlie Reis, 2016-07-25 18:28:38]

Description was changed from

==========
Simplify EncodePageState to return no value.

It was never able to return false, which led to unnecessary error
case handling.  Removing the return value makes reasoning about
invalid PageStates easier.

BUG=568703
TEST=No behavior change.
==========

to

==========
Simplify EncodePageState to return no value.

It was never able to return false, which led to unnecessary error
case handling.  Removing the return value makes reasoning about
invalid PageStates easier.

BUG=568703
TEST=No behavior change.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2016-07-25 18:30:02]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 18:30:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-07-25 18:31:12]

creis@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Reis, 2016-07-25 18:31:13]

There should be no behavior change here, but PageState code will be easier to
reason about.

[nasko, 2016-07-25 18:39:30]

LGTM

[commit-bot: I haz the power, 2016-07-25 19:43:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:43:46]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-07-25 19:49:51]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:50:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 19:54:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 19:59:34]

Description was changed from

==========
Simplify EncodePageState to return no value.

It was never able to return false, which led to unnecessary error
case handling.  Removing the return value makes reasoning about
invalid PageStates easier.

BUG=568703
TEST=No behavior change.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Simplify EncodePageState to return no value.

It was never able to return false, which led to unnecessary error
case handling.  Removing the return value makes reasoning about
invalid PageStates easier.

BUG=568703
TEST=No behavior change.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/20ada69560e72b05b08787483c442addf37624ee
Cr-Commit-Position: refs/heads/master@{#407552}
==========

[commit-bot: I haz the power, 2016-07-25 19:59:35]

Patchset 1 (id:??) landed as
https://crrev.com/20ada69560e72b05b08787483c442addf37624ee
Cr-Commit-Position: refs/heads/master@{#407552}