Issue 2181743003: Reland "Remove all safesync functionality from gclient"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2181743003: Reland "Remove all safesync functionality from gclient"

Created:
4 years, 4 months ago by agable

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Reland "Remove all safesync functionality from gclient" This reverts most of commit ae7ea3167e96a546cb93949967d3d2ac0be89262. This relands commit 99a7f805785be9e44f01886fa95ecc162edf2774. This relands commit 2697cd19a7853609a4f06537306c9e5b8d34c65d. This relands commit 8c51b6f1487c79647ea9d3299f776ea4e211fafe. This does not reland commit d4aedc811b6d4c9a077fa9166de23974d5d4ba06. This also includes a fix for the reason for the original revert. BUG=624178

Patch Set 1 #

Patch Set 2 : Introduce the fix #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -331 lines)			Patch
M	fetch_configs/breakpad.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/chromium.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/dart.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/dartino.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/dartium.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/gyp.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/ios_internal.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/mojo.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/nacl.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/naclports.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/v8.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	fetch_configs/webrtc.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gclient.py	View		17 chunks	+29 lines, -69 lines	0 comments	Download
M	gclient_scm.py	View	1	4 chunks	+6 lines, -88 lines	0 comments	Download
M	recipe_modules/bot_update/resources/bot_update.py	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	recipe_modules/gclient/api.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	recipe_modules/gclient/config.py	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	recipe_modules/gclient/example.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	recipe_modules/gclient/example.expected/basic.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	recipe_modules/gclient/example.expected/revision.json	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	recipe_modules/gclient/example.expected/tryserver.json	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/gclient_scm_test.py	View		1 chunk	+0 lines, -100 lines	0 comments	Download
M	tests/gclient_smoketest.py	View		4 chunks	+10 lines, -28 lines	0 comments	Download
M	tests/gclient_test.py	View		3 chunks	+7 lines, -7 lines	0 comments	Download