recipe_modules/bot_update/resources/bot_update.py - Issue 2181743003: Reland "Remove all safesync functionality from gclient"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/bot_update/resources/bot_update.py

Issue 2181743003: Reland "Remove all safesync functionality from gclient" Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Introduce the fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/bot_update/resources/bot_update.py

diff --git a/recipe_modules/bot_update/resources/bot_update.py b/recipe_modules/bot_update/resources/bot_update.py

index bfc7b7feb67bdf12e1266e288474aea9d75878e4..ac4254dd292d9f1cf6ddef94e77e2812195021ba 100755

--- a/recipe_modules/bot_update/resources/bot_update.py

+++ b/recipe_modules/bot_update/resources/bot_update.py

@@ -653,12 +653,6 @@ def solutions_to_git(input_solutions):

first_solution = False

solution['managed'] = False

- # We don't want gclient to be using a safesync URL. Instead it should

- # using the lkgr/lkcr branch/tags.

- if 'safesync_url' in solution:

- print 'Removing safesync url %s from %s' % (solution['safesync_url'],

- parsed_path)

- del solution['safesync_url']

return solutions, root, buildspec

« no previous file with comments | « gclient_scm.py ('k') | recipe_modules/gclient/api.py » ('j') | no next file with comments »