Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2181693002:
Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. (Closed)
|
Created:
4 years, 5 months ago by stkhapugin Modified:
4 years, 5 months ago CC:
chromium-reviews, sdefresne+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisables AlertCoordinatorTest.ValidateDismissalOnDestroy.
This test is failing on Xcode 8 bot.
BUG=631049
Committed: https://crrev.com/63b419b33fd5f59b0756cd40f3d595584df0463c
Cr-Commit-Position: refs/heads/master@{#407748}
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
stkhapugin@chromium.org changed reviewers: + gambard@chromium.org
PTAL
lgtm
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. This test is failing on Xcode 8 bot. BUG=631049 ========== to ========== Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. This test is failing on Xcode 8 bot. BUG=631049 ==========
stkhapugin@chromium.org changed reviewers: + sdefresne@chromium.org
+sdefresne for committer
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. This test is failing on Xcode 8 bot. BUG=631049 ========== to ========== Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. This test is failing on Xcode 8 bot. BUG=631049 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. This test is failing on Xcode 8 bot. BUG=631049 ========== to ========== Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. This test is failing on Xcode 8 bot. BUG=631049 Committed: https://crrev.com/63b419b33fd5f59b0756cd40f3d595584df0463c Cr-Commit-Position: refs/heads/master@{#407748} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/63b419b33fd5f59b0756cd40f3d595584df0463c Cr-Commit-Position: refs/heads/master@{#407748} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
