ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm - Issue 2181693002: Disables AlertCoordinatorTest.ValidateDismissalOnDestroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm

Issue 2181693002: Disables AlertCoordinatorTest.ValidateDismissalOnDestroy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm

diff --git a/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm b/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm

index 93ddae3abfc155cf5b234921fd504b4e7a03bacb..43d73fdb00fa60ede3672364efad368357b2450b 100644

--- a/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm

+++ b/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm

@@ -149,7 +149,8 @@ TEST_F(AlertCoordinatorTest, ValidateDismissalOnStop) {

}

// Tests the alert coordinator dismissal when the object is destroyed.

-TEST_F(AlertCoordinatorTest, ValidateDismissalOnDestroy) {

+// TODO(crbug.com/631049): This test is failing on Xcode 8 bot.

+TEST_F(AlertCoordinatorTest, DISABLED_ValidateDismissalOnDestroy) {

// Setup.

UIViewController* viewController = getViewController();

AlertCoordinator* alertCoordinator = getAlertCoordinator(viewController);

« no previous file with comments | « no previous file | no next file » | no next file with comments »