[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

BUG=chromium:631094
R=ulan@chromium.org

Committed: https://crrev.com/3d4ddb30096e6a55be8926c400a67e819a05f3c2
Cr-Commit-Position: refs/heads/master@{#38032}

[Michael Lippautz, 2016-07-25 16:42:00]

Description was changed from

==========
[heap] ObjectStats: Cleanup

BUG=
==========

to

==========
[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

R=ulan@chromium.org
==========

[Michael Lippautz, 2016-07-25 16:42:01]

mlippautz@chromium.org changed reviewers:
+ ulan@chromium.org

[Michael Lippautz, 2016-07-25 16:42:11]

ptal

[Michael Lippautz, 2016-07-25 16:46:27]

Description was changed from

==========
[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

R=ulan@chromium.org
==========

to

==========
[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

BUG=chromium:631094
R=ulan@chromium.org
==========

[ulan, 2016-07-25 16:47:30]

lgtm

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.cc
File src/heap/object-stats.cc (right):

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.c...
src/heap/object-stats.cc:237: static bool CowArray(Heap* heap, FixedArrayBase*
array) {
Nit: IsCowArray

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.c...
src/heap/object-stats.cc:455: if (array->map() == heap_->fixed_cow_array_map())
{
if (IsCowArray(heap, array) &&...

[Michael Lippautz, 2016-07-25 16:52:00]

Patchset #4 (id:60001) has been deleted

[Michael Lippautz, 2016-07-25 16:52:29]

thanks!

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.cc
File src/heap/object-stats.cc (right):

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.c...
src/heap/object-stats.cc:237: static bool CowArray(Heap* heap, FixedArrayBase*
array) {
On 2016/07/25 16:47:30, ulan wrote:
> Nit: IsCowArray

Done.

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.c...
src/heap/object-stats.cc:455: if (array->map() == heap_->fixed_cow_array_map())
{
On 2016/07/25 16:47:30, ulan wrote:
> if (IsCowArray(heap, array) &&...

Done.

[Michael Lippautz, 2016-07-25 16:52:29]

thanks!

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.cc
File src/heap/object-stats.cc (right):

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.c...
src/heap/object-stats.cc:237: static bool CowArray(Heap* heap, FixedArrayBase*
array) {
On 2016/07/25 16:47:30, ulan wrote:
> Nit: IsCowArray

Done.

https://codereview.chromium.org/2181623002/diff/40001/src/heap/object-stats.c...
src/heap/object-stats.cc:455: if (array->map() == heap_->fixed_cow_array_map())
{
On 2016/07/25 16:47:30, ulan wrote:
> if (IsCowArray(heap, array) &&...

Done.

[Michael Lippautz, 2016-07-25 16:52:35]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 16:52:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 17:18:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 17:18:16]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-07-25 17:40:39]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-07-25 17:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2181623002/#ps80001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-07-25 17:40:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 17:41:59]

Description was changed from

==========
[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

BUG=chromium:631094
R=ulan@chromium.org
==========

to

==========
[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

BUG=chromium:631094
R=ulan@chromium.org
==========

[commit-bot: I haz the power, 2016-07-25 17:42:00]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-07-25 17:43:11]

Description was changed from

==========
[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

BUG=chromium:631094
R=ulan@chromium.org
==========

to

==========
[heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types

Reduces the dark matter of reported fixed arrays to < 5%.

BUG=chromium:631094
R=ulan@chromium.org

Committed: https://crrev.com/3d4ddb30096e6a55be8926c400a67e819a05f3c2
Cr-Commit-Position: refs/heads/master@{#38032}
==========

[commit-bot: I haz the power, 2016-07-25 17:43:12]

Patchset 4 (id:??) landed as
https://crrev.com/3d4ddb30096e6a55be8926c400a67e819a05f3c2
Cr-Commit-Position: refs/heads/master@{#38032}