Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: src/objects-inl.h

Issue 2181623002: [heap] ObjectStats: Cleanup and more FIXED_ARRAY sub types (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 TYPE_CHECKER(JSContextExtensionObject, JS_CONTEXT_EXTENSION_OBJECT_TYPE) 698 TYPE_CHECKER(JSContextExtensionObject, JS_CONTEXT_EXTENSION_OBJECT_TYPE)
699 TYPE_CHECKER(Map, MAP_TYPE) 699 TYPE_CHECKER(Map, MAP_TYPE)
700 TYPE_CHECKER(FixedDoubleArray, FIXED_DOUBLE_ARRAY_TYPE) 700 TYPE_CHECKER(FixedDoubleArray, FIXED_DOUBLE_ARRAY_TYPE)
701 TYPE_CHECKER(WeakFixedArray, FIXED_ARRAY_TYPE) 701 TYPE_CHECKER(WeakFixedArray, FIXED_ARRAY_TYPE)
702 TYPE_CHECKER(TransitionArray, TRANSITION_ARRAY_TYPE) 702 TYPE_CHECKER(TransitionArray, TRANSITION_ARRAY_TYPE)
703 703
704 bool HeapObject::IsJSWeakCollection() const { 704 bool HeapObject::IsJSWeakCollection() const {
705 return IsJSWeakMap() || IsJSWeakSet(); 705 return IsJSWeakMap() || IsJSWeakSet();
706 } 706 }
707 707
708 bool HeapObject::IsJSCollection() const { return IsJSMap() || IsJSSet(); }
709
708 bool HeapObject::IsDescriptorArray() const { return IsFixedArray(); } 710 bool HeapObject::IsDescriptorArray() const { return IsFixedArray(); }
709 711
710 bool HeapObject::IsArrayList() const { return IsFixedArray(); } 712 bool HeapObject::IsArrayList() const { return IsFixedArray(); }
711 713
712 bool Object::IsLayoutDescriptor() const { 714 bool Object::IsLayoutDescriptor() const {
713 return IsSmi() || IsFixedTypedArrayBase(); 715 return IsSmi() || IsFixedTypedArrayBase();
714 } 716 }
715 717
716 bool HeapObject::IsTypeFeedbackVector() const { return IsFixedArray(); } 718 bool HeapObject::IsTypeFeedbackVector() const { return IsFixedArray(); }
717 719
(...skipping 7396 matching lines...) Expand 10 before | Expand all | Expand 10 after
8114 #undef WRITE_INT64_FIELD 8116 #undef WRITE_INT64_FIELD
8115 #undef READ_BYTE_FIELD 8117 #undef READ_BYTE_FIELD
8116 #undef WRITE_BYTE_FIELD 8118 #undef WRITE_BYTE_FIELD
8117 #undef NOBARRIER_READ_BYTE_FIELD 8119 #undef NOBARRIER_READ_BYTE_FIELD
8118 #undef NOBARRIER_WRITE_BYTE_FIELD 8120 #undef NOBARRIER_WRITE_BYTE_FIELD
8119 8121
8120 } // namespace internal 8122 } // namespace internal
8121 } // namespace v8 8123 } // namespace v8
8122 8124
8123 #endif // V8_OBJECTS_INL_H_ 8125 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698