content/browser/service_worker/service_worker_unregister_job.h - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_unregister_job.h

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_storage_unittest.cc ('k') | content/browser/service_worker/service_worker_unregister_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_unregister_job.h

diff --git a/content/browser/service_worker/service_worker_unregister_job.h b/content/browser/service_worker/service_worker_unregister_job.h

index a614253f076ec0132aba940ec1f733bd93377068..517bc27b0af29b953fdcc1217c2f33ec55091a3b 100644

--- a/content/browser/service_worker/service_worker_unregister_job.h

+++ b/content/browser/service_worker/service_worker_unregister_job.h

@@ -51,7 +51,7 @@ class ServiceWorkerUnregisterJob : public ServiceWorkerRegisterJobBase {

private:

void OnRegistrationFound(

ServiceWorkerStatusCode status,

- const scoped_refptr<ServiceWorkerRegistration>& registration);

+ scoped_refptr<ServiceWorkerRegistration> registration);

void Complete(int64_t registration_id, ServiceWorkerStatusCode status);

void CompleteInternal(int64_t registration_id,

ServiceWorkerStatusCode status);