Issue 218153002: Slightly simplify icu.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218153002: Slightly simplify icu.gyp. (Closed)

Created:
6 years, 8 months ago by Nico

Modified:
6 years, 8 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
http://src.chromium.org/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

More Reviews

Description

Slightly simplify icu.gyp. xcode_settings, msvs_settings, and cflags are only used on mac, windows, and elsewhere respectively, so there's no need to put them in conditionals.

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -45 lines)			Patch
	M	icu.gyp	View	1	4 chunks	+33 lines, -45 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

6 years, 8 months ago (2014-04-01 16:23:36 UTC) #2

LGTM.  
I'll copy over this change to ICU 52 that I'm adding.

Expand Messages | Collapse Messages