Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136, 631415
Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Committed: https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940
Cr-Original-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Original-Commit-Position: refs/heads/master@{#408644}
Cr-Commit-Position: refs/heads/master@{#413921}

[yzshen1, 2016-07-23 00:22:55]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 00:23:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-07-23 00:31:24]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[yzshen1, 2016-07-23 00:31:46]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-07-23 00:31:46]

Hi, Ken.

Please take a look. Thanks!

[commit-bot: I haz the power, 2016-07-23 00:32:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 00:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 00:43:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-07-23 00:55:46]

lgtm

[yzshen1, 2016-07-23 02:19:46]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-07-23 02:20:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 03:38:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-23 03:40:47]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

[commit-bot: I haz the power, 2016-07-23 03:40:49]

Patchset 2 (id:??) landed as
https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}

[yzshen1, 2016-07-26 23:07:22]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2183963002/ by yzshen@chromium.org.

The reason for reverting is: It seems this caused perf regression:
https://bugs.chromium.org/p/chromium/issues/detail?id=631415.

[yzshen1, 2016-07-28 23:01:37]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

[yzshen1, 2016-07-28 23:49:42]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[yzshen1, 2016-07-28 23:50:07]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

[commit-bot: I haz the power, 2016-07-28 23:50:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-07-28 23:51:07]

Hi, Ken.

Do you feel like to look at changes in
mojo/public/cpp/bindings/array_traits_stl.h? Thanks!

[Ken Rockot(use gerrit already), 2016-07-29 00:05:19]

lgtm

[commit-bot: I haz the power, 2016-07-29 01:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 01:03:22]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2016-07-29 15:42:18]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-07-29 15:42:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 15:45:43]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

[commit-bot: I haz the power, 2016-07-29 15:45:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-29 15:47:11]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Cr-Commit-Position: refs/heads/master@{#407340}
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Cr-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Commit-Position: refs/heads/master@{#408644}
==========

[commit-bot: I haz the power, 2016-07-29 15:47:12]

Patchset 3 (id:??) landed as
https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Cr-Commit-Position: refs/heads/master@{#408644}

[benwells, 2016-08-01 04:32:01]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2199623002/ by benwells@chromium.org.

The reason for reverting is: This patch has broken compiling on the MSan bots.

Due to memory waterfall shenanigans I haven't had time to investigate why, but I
do know that locally reverting this change fixed compile.

Sample failure output:
FAILED:
obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o

/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF
obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o.d
-DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS
-DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC
-DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE
-DMEMORY_SANITIZER -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1
-DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=274369-1 -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DENABLE_OILPAN=1
-DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DWTF_USE_ICCJPEG=1
-DWTF_USE_QCMSLIB=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT=
-DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink
-Igen/third_party/WebKit -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n -fno-strict-aliasing
--param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
-fdebug-prefix-map=/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src=. -pthread
-m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
-Wno-deprecated-register -Wno-unneeded-internal-declaration
-Wno-inconsistent-missing-override -Wno-shift-negative-value
-Wno-undefined-var-template -Wno-nonportable-include-path -O2 -fno-ident
-fdata-sections -ffunction-sections -g1
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot -gline-tables-only
-fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins=2
-fsanitize-blacklist=../../tools/msan/blacklist.txt -fvisibility=hidden -Xclang
-load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang
follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang
check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang
check-ipc -Wheader-hygiene -Wstring-conversion -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang
-add-plugin -Xclang blink-gc-plugin -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -nostdinc++
-isystem../../buildtools/third_party/libc++/trunk/include
-isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c
gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc -o
obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o
In file included from
gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc:15:
In file included from
gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.h:37:
In file included from
gen/mojo/public/interfaces/bindings/tests/rect.mojom-blink.h:37:
In file included from ../../mojo/public/cpp/bindings/wtf_array.h:15:
In file included from
../../mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h:13:
../../third_party/WebKit/Source/wtf/Vector.h:196:32: error: call to deleted
constructor of 'mojo::ScopedHandleBase<mojo::Handle>'
            new (NotNull, dst) T(*src);
                               ^ ~~~~
../../third_party/WebKit/Source/wtf/Vector.h:323:62: note: in instantiation of
function template specialization 'WTF::VectorCopier<false,
mojo::ScopedHandleBase<mojo::Handle>
>::uninitializedCopy<mojo::ScopedHandleBase<mojo::Handle> >' requested here
        VectorCopier<VectorTraits<T>::canCopyWithMemcpy,
T>::uninitializedCopy(src, srcEnd, dst);
                                                             ^
../../third_party/WebKit/Source/wtf/Vector.h:1004:21: note: in instantiation of
member function 'WTF::VectorTypeOperations<mojo::ScopedHandleBase<mojo::Handle>
>::uninitializedCopy' requested here
    TypeOperations::uninitializedCopy(other.begin(), other.end(), begin());
                    ^
../../buildtools/third_party/libc++/trunk/include/memory:1740:31: note: in
instantiation of member function
'WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator>::Vector' requested here
            ::new((void*)__p) _Up(_VSTD::forward<_Args>(__args)...);
                              ^
../../buildtools/third_party/libc++/trunk/include/memory:1656:18: note: in
instantiation of function template specialization
'std::__1::allocator<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator>
>::construct<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator>, const
WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>
&>' requested here
            {__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
                 ^
../../buildtools/third_party/libc++/trunk/include/memory:1502:14: note: in
instantiation of function template specialization
'std::__1::allocator_traits<std::__1::allocator<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>,
0, WTF::PartitionAllocator> >
>::__construct<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator>, const
WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>
&>' requested here
            {__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
             ^
../../buildtools/third_party/libc++/trunk/include/memory:1618:17: note:
(skipping 5 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
                construct(__a, _VSTD::__to_raw_pointer(__end2-1),
_VSTD::move_if_noexcept(*--__end1));
                ^
../../mojo/public/cpp/bindings/lib/array_serialization.h:395:18: note: in
instantiation of member function
'mojo::ArrayTraits<std::__1::vector<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>,
0, WTF::PartitionAllocator>,
std::__1::allocator<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator> > > >::Resize' requested here
    if (!Traits::Resize(*output, input->size()))
                 ^
../../mojo/public/cpp/bindings/lib/map_serialization.h:162:32: note: in
instantiation of member function
'mojo::internal::ArraySerializer<mojo::Array<mojo::Array<mojo::ScopedHandleBase<mojo::Handle>
> >, std::__1::vector<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator>,
std::__1::allocator<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator> > >,
mojo::internal::MapValueReader<WTF::HashMap<WTF::String,
WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>,
WTF::StringHash, WTF::HashTraits<WTF::String>,
WTF::HashTraits<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator> >, WTF::PartitionAllocator> >,
void>::DeserializeElements' requested here
        !ValueArraySerializer::DeserializeElements(input->values.Get(), &values,
                               ^
../../mojo/public/cpp/bindings/lib/serialization_forward.h:69:48: note: in
instantiation of member function
'mojo::internal::Serializer<mojo::Map<mojo::String,
mojo::Array<mojo::ScopedHandleBase<mojo::Handle> > >, WTF::HashMap<WTF::String,
WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>,
WTF::StringHash, WTF::HashTraits<WTF::String>,
WTF::HashTraits<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator> >, WTF::PartitionAllocator> >::Deserialize' requested
here
  return Serializer<MojomType, InputUserType>::Deserialize(
                                               ^
gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.h:1546:28:
note: in instantiation of function template specialization
'mojo::internal::Deserialize<mojo::Map<mojo::String,
mojo::Array<mojo::ScopedHandleBase<mojo::Handle> > >,
mojo::internal::Map_Data<mojo::internal::Pointer<mojo::internal::Array_Data<char>
>,
mojo::internal::Pointer<mojo::internal::Array_Data<mojo::internal::Handle_Data>
> > *&, WTF::HashMap<WTF::String,
WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>,
WTF::StringHash, WTF::HashTraits<WTF::String>,
WTF::HashTraits<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator> >, WTF::PartitionAllocator>,
mojo::internal::SerializationContext *&, nullptr>' requested here
    return mojo::internal::Deserialize<mojo::Map<mojo::String,
mojo::Array<mojo::ScopedHandle>>>(
                           ^
gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc:4029:18:
note: in instantiation of function template specialization
'mojo::test::blink::MapValueTypesDataView::ReadF10<WTF::HashMap<WTF::String,
WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>,
WTF::StringHash, WTF::HashTraits<WTF::String>,
WTF::HashTraits<WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0,
WTF::PartitionAllocator> >, WTF::PartitionAllocator> >' requested here
      if (!input.ReadF10(&result->f10))
                 ^
../../mojo/public/cpp/system/handle.h:135:28: note: 'ScopedHandleBase' has been
explicitly marked deleted here
  DISALLOW_COPY_AND_ASSIGN(ScopedHandleBase);
                           ^
.

[yzshen1, 2016-08-23 22:00:28]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Cr-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Commit-Position: refs/heads/master@{#408644}
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Cr-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Commit-Position: refs/heads/master@{#408644}
==========

[yzshen1, 2016-08-23 22:00:32]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-08-23 22:00:33]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2181443002/#ps60001
(title: "Make further change to array_traits_stl.h to make MSan build happy.")

[commit-bot: I haz the power, 2016-08-23 22:02:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 23:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 23:30:10]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yzshen1, 2016-08-23 23:32:04]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-23 23:33:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:10:31]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Cr-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Commit-Position: refs/heads/master@{#408644}
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Cr-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Commit-Position: refs/heads/master@{#408644}
==========

[commit-bot: I haz the power, 2016-08-24 01:10:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 01:14:12]

Description was changed from

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Cr-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Commit-Position: refs/heads/master@{#408644}
==========

to

==========
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

BUG=624136,631415

Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Committed: https://crrev.com/887252e6ab811d0cc047e3e32f033307215e11d3
Committed: https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940
Cr-Original-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Original-Commit-Position: refs/heads/master@{#408644}
Cr-Commit-Position: refs/heads/master@{#413921}
==========

[commit-bot: I haz the power, 2016-08-24 01:14:14]

Patchset 4 (id:??) landed as
https://crrev.com/24b40a317881cf6e23baeafb79fdbb277ed58940
Cr-Commit-Position: refs/heads/master@{#413921}