ipc/ipc_message_pipe_reader.h - Issue 2181443002: Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_pipe_reader.h

Issue 2181443002: Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make further change to array_traits_stl.h to make MSan build happy. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_message_pipe_reader.h

diff --git a/ipc/ipc_message_pipe_reader.h b/ipc/ipc_message_pipe_reader.h

index e6a2a137a0a39930266c1400977befb13d10c51a..c00cab4bfee6b58383cd4446bccfcbf92ae63841 100644

--- a/ipc/ipc_message_pipe_reader.h

+++ b/ipc/ipc_message_pipe_reader.h

@@ -95,10 +95,11 @@ class IPC_EXPORT MessagePipeReader : public NON_EXPORTED_BASE(mojom::Channel) {

private:

// mojom::Channel:

void SetPeerPid(int32_t peer_pid) override;

- void Receive(mojo::Array<uint8_t> data,

- mojo::Array<mojom::SerializedHandlePtr> handles) override;

+ void Receive(

+ const std::vector<uint8_t>& data,

+ base::Optional<std::vector<mojom::SerializedHandlePtr>> handles) override;

void GetAssociatedInterface(

- const mojo::String& name,

+ const std::string& name,

mojom::GenericInterfaceAssociatedRequest request) override;

// |delegate_| is null once the message pipe is closed.

« no previous file with comments | « ipc/ipc_channel_mojo.cc ('k') | ipc/ipc_message_pipe_reader.cc » ('j') | no next file with comments »