Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2181413004: If cit is run with an unknown tool, print usage rather than throwing an exception (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

If cit is run with an unknown tool, print usage rather than throwing an exception BUG= TBR=hinoka Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/72decfedaa9650d843c2c4e9c0c0e1fcbe226331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M cit.py View 2 chunks +27 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
dsansome
4 years, 4 months ago (2016-07-27 04:25:03 UTC) #2
Ryan Tseng
lgtm
4 years, 4 months ago (2016-08-01 23:14:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181413004/1
4 years, 4 months ago (2016-08-02 03:33:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30622248defd0710)
4 years, 4 months ago (2016-08-02 03:39:41 UTC) #8
dsansome
On 2016/08/02 03:39:41, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-02 03:52:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181413004/1
4 years, 4 months ago (2016-08-02 03:52:51 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 03:55:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/72decfedaa9650...

Powered by Google App Engine
This is Rietveld 408576698