Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194383003: Add google.com OWNERS (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add google.com OWNERS BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M OWNERS View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsansome
4 years, 4 months ago (2016-08-02 03:52:54 UTC) #2
Dirk Pranke
We don't generally encourage people to commit from different addresses or review from different addresses, ...
4 years, 4 months ago (2016-08-02 16:23:13 UTC) #4
dsansome
On 2016/08/02 16:23:13, Dirk Pranke wrote: > We don't generally encourage people to commit from ...
4 years, 4 months ago (2016-08-03 03:50:02 UTC) #5
Dirk Pranke
4 years, 4 months ago (2016-08-03 04:01:34 UTC) #7
Message was sent while issue was closed. 
On 2016/08/03 03:50:02, dsansome wrote:
> On 2016/08/02 16:23:13, Dirk Pranke wrote:
> > We don't generally encourage people to commit from different addresses or
> review
> > from different addresses, so I'm not sure this CL is a good idea.
> 
> Fair enough, I'll close it.  The context was I wanted to submit
> https://codereview.chromium.org/2181413004/ that Ryan LGTM'd from the wrong
> account.

Yup, it's an understandable annoyance to want to fix.

Powered by Google App Engine
This is Rietveld 408576698