Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2181333002: Print malloc-ed memory when running with --trace-gc-object-stats. (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Print malloc-ed memory when running with --trace-gc-object-stats. BUG=chromium:631094 Committed: https://crrev.com/f91727d1523c996d7108988b8015718031c1d941 Cr-Commit-Position: refs/heads/master@{#38066}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -13 lines) Patch
M src/base/accounting-allocator.h View 1 chunk +4 lines, -4 lines 1 comment Download
M src/isolate.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/isolate.cc View 4 chunks +61 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Michael Lippautz
ptal
4 years, 4 months ago (2016-07-26 15:42:12 UTC) #3
Hannes Payer (out of office)
lgtm
4 years, 4 months ago (2016-07-26 16:04:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181333002/1
4 years, 4 months ago (2016-07-26 16:52:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 16:53:49 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f91727d1523c996d7108988b8015718031c1d941 Cr-Commit-Position: refs/heads/master@{#38066}
4 years, 4 months ago (2016-07-26 16:54:32 UTC) #14
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-05 10:00:26 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/2181333002/diff/1/src/base/accounting-allocat...
File src/base/accounting-allocator.h (right):

https://codereview.chromium.org/2181333002/diff/1/src/base/accounting-allocat...
src/base/accounting-allocator.h:17: virtual ~AccountingAllocator() = default;
instead of making this virtual, you could have just moved the class out of base/
and added the tracking stuff to the allocator itself.

Not sure whether the additional checks are more expensive or paying for a
virtual lookup on every call...

Powered by Google App Engine
This is Rietveld 408576698