Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: src/base/accounting-allocator.h

Issue 2181333002: Print malloc-ed memory when running with --trace-gc-object-stats. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/accounting-allocator.h
diff --git a/src/base/accounting-allocator.h b/src/base/accounting-allocator.h
index ad2fc988cc89c29d37fc31aa1410a2f5ad277f86..4e1baf18d4d57a37510f98ae4fa10d65a7c9f7ae 100644
--- a/src/base/accounting-allocator.h
+++ b/src/base/accounting-allocator.h
@@ -11,14 +11,14 @@
namespace v8 {
namespace base {
-class AccountingAllocator final {
+class AccountingAllocator {
public:
AccountingAllocator() = default;
- ~AccountingAllocator() = default;
+ virtual ~AccountingAllocator() = default;
jochen (gone - plz use gerrit) 2016/09/05 10:00:26 instead of making this virtual, you could have jus
// Returns nullptr on failed allocation.
- void* Allocate(size_t bytes);
- void Free(void* memory, size_t bytes);
+ virtual void* Allocate(size_t bytes);
+ virtual void Free(void* memory, size_t bytes);
size_t GetCurrentMemoryUsage() const;
size_t GetMaxMemoryUsage() const;
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698