Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp

Issue 2181243002: Move ThreadableLoader to Oilpan heap (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('K') | « third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp » ('j') | third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
index 50c03d4bab570fceaa206d45149246ba1e582680..b49316cadfc7d072962900eae4f12073d30c9d11 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
@@ -53,12 +53,7 @@ using Checkpoint = StrictMock<::testing::MockFunction<void(int)>>;
class MockLoaderFactory : public FetchBlobDataConsumerHandle::LoaderFactory {
public:
- std::unique_ptr<ThreadableLoader> create(ExecutionContext& executionContext, ThreadableLoaderClient* client, const ThreadableLoaderOptions& threadableLoaderOptions, const ResourceLoaderOptions& resourceLoaderOptions) override
- {
- return wrapUnique(createInternal(executionContext, client, threadableLoaderOptions, resourceLoaderOptions));
- }
-
- MOCK_METHOD4(createInternal, ThreadableLoader*(ExecutionContext&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&));
+ MOCK_METHOD4(create, ThreadableLoader*(ExecutionContext&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&));
};
PassRefPtr<BlobDataHandle> createBlobDataHandle(const char* s)
@@ -100,18 +95,17 @@ TEST_F(FetchBlobDataConsumerHandleTest, CreateLoader)
ThreadableLoaderOptions options;
ResourceLoaderOptions resourceLoaderOptions;
- std::unique_ptr<MockThreadableLoader> loader = MockThreadableLoader::create();
- MockThreadableLoader* loaderPtr = loader.get();
+ Persistent<MockThreadableLoader> loader = MockThreadableLoader::create();
InSequence s;
EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*factory, createInternal(Ref(document()), _, _, _)).WillOnce(DoAll(
+ EXPECT_CALL(*factory, create(Ref(document()), _, _, _)).WillOnce(DoAll(
SaveArg<2>(&options),
SaveArg<3>(&resourceLoaderOptions),
- Return(loader.release())));
- EXPECT_CALL(*loaderPtr, start(_)).WillOnce(SaveArg<0>(&request));
+ Return(loader.get())));
+ EXPECT_CALL(*loader, start(_)).WillOnce(SaveArg<0>(&request));
EXPECT_CALL(checkpoint, Call(2));
- EXPECT_CALL(*loaderPtr, cancel());
+ EXPECT_CALL(*loader, cancel());
RefPtr<BlobDataHandle> blobDataHandle = createBlobDataHandle("Once upon a time");
std::unique_ptr<WebDataConsumerHandle> handle
@@ -145,15 +139,14 @@ TEST_F(FetchBlobDataConsumerHandleTest, CancelLoaderWhenStopped)
auto factory = new StrictMock<MockLoaderFactory>;
Checkpoint checkpoint;
- std::unique_ptr<MockThreadableLoader> loader = MockThreadableLoader::create();
- MockThreadableLoader* loaderPtr = loader.get();
+ Persistent<MockThreadableLoader> loader = MockThreadableLoader::create();
InSequence s;
EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*factory, createInternal(Ref(document()), _, _, _)).WillOnce(Return(loader.release()));
- EXPECT_CALL(*loaderPtr, start(_));
+ EXPECT_CALL(*factory, create(Ref(document()), _, _, _)).WillOnce(Return(loader.get()));
+ EXPECT_CALL(*loader, start(_));
EXPECT_CALL(checkpoint, Call(2));
- EXPECT_CALL(*loaderPtr, cancel());
+ EXPECT_CALL(*loader, cancel());
EXPECT_CALL(checkpoint, Call(3));
RefPtr<BlobDataHandle> blobDataHandle = createBlobDataHandle("Once upon a time");
@@ -175,16 +168,15 @@ TEST_F(FetchBlobDataConsumerHandleTest, CancelLoaderWhenDestinationDetached)
auto factory = new StrictMock<MockLoaderFactory>;
Checkpoint checkpoint;
- std::unique_ptr<MockThreadableLoader> loader = MockThreadableLoader::create();
- MockThreadableLoader* loaderPtr = loader.get();
+ Persistent<MockThreadableLoader> loader = MockThreadableLoader::create();
InSequence s;
EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*factory, createInternal(Ref(document()), _, _, _)).WillOnce(Return(loader.release()));
- EXPECT_CALL(*loaderPtr, start(_));
+ EXPECT_CALL(*factory, create(Ref(document()), _, _, _)).WillOnce(Return(loader.get()));
+ EXPECT_CALL(*loader, start(_));
EXPECT_CALL(checkpoint, Call(2));
EXPECT_CALL(checkpoint, Call(3));
- EXPECT_CALL(*loaderPtr, cancel());
+ EXPECT_CALL(*loader, cancel());
EXPECT_CALL(checkpoint, Call(4));
RefPtr<BlobDataHandle> blobDataHandle = createBlobDataHandle("Once upon a time");
@@ -210,16 +202,15 @@ TEST_F(FetchBlobDataConsumerHandleTest, ReadTest)
auto factory = new StrictMock<MockLoaderFactory>;
Checkpoint checkpoint;
- std::unique_ptr<MockThreadableLoader> loader = MockThreadableLoader::create();
- MockThreadableLoader* loaderPtr = loader.get();
+ Persistent<MockThreadableLoader> loader = MockThreadableLoader::create();
ThreadableLoaderClient* client = nullptr;
InSequence s;
EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*factory, createInternal(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.release())));
- EXPECT_CALL(*loaderPtr, start(_));
+ EXPECT_CALL(*factory, create(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.get())));
+ EXPECT_CALL(*loader, start(_));
EXPECT_CALL(checkpoint, Call(2));
- EXPECT_CALL(*loaderPtr, cancel());
+ EXPECT_CALL(*loader, cancel());
RefPtr<BlobDataHandle> blobDataHandle = createBlobDataHandle("Once upon a time");
std::unique_ptr<WebDataConsumerHandle> handle
@@ -249,16 +240,15 @@ TEST_F(FetchBlobDataConsumerHandleTest, TwoPhaseReadTest)
auto factory = new StrictMock<MockLoaderFactory>;
Checkpoint checkpoint;
- std::unique_ptr<MockThreadableLoader> loader = MockThreadableLoader::create();
- MockThreadableLoader* loaderPtr = loader.get();
+ Persistent<MockThreadableLoader> loader = MockThreadableLoader::create();
ThreadableLoaderClient* client = nullptr;
InSequence s;
EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*factory, createInternal(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.release())));
- EXPECT_CALL(*loaderPtr, start(_));
+ EXPECT_CALL(*factory, create(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.get())));
+ EXPECT_CALL(*loader, start(_));
EXPECT_CALL(checkpoint, Call(2));
- EXPECT_CALL(*loaderPtr, cancel());
+ EXPECT_CALL(*loader, cancel());
RefPtr<BlobDataHandle> blobDataHandle = createBlobDataHandle("Once upon a time");
std::unique_ptr<WebDataConsumerHandle> handle
@@ -288,14 +278,13 @@ TEST_F(FetchBlobDataConsumerHandleTest, LoadErrorTest)
auto factory = new StrictMock<MockLoaderFactory>;
Checkpoint checkpoint;
- std::unique_ptr<MockThreadableLoader> loader = MockThreadableLoader::create();
- MockThreadableLoader* loaderPtr = loader.get();
+ Persistent<MockThreadableLoader> loader = MockThreadableLoader::create();
ThreadableLoaderClient* client = nullptr;
InSequence s;
EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*factory, createInternal(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.release())));
- EXPECT_CALL(*loaderPtr, start(_));
+ EXPECT_CALL(*factory, create(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.get())));
+ EXPECT_CALL(*loader, start(_));
EXPECT_CALL(checkpoint, Call(2));
RefPtr<BlobDataHandle> blobDataHandle = createBlobDataHandle("Once upon a time");
@@ -318,16 +307,15 @@ TEST_F(FetchBlobDataConsumerHandleTest, BodyLoadErrorTest)
auto factory = new StrictMock<MockLoaderFactory>;
Checkpoint checkpoint;
- std::unique_ptr<MockThreadableLoader> loader = MockThreadableLoader::create();
- MockThreadableLoader* loaderPtr = loader.get();
+ Persistent<MockThreadableLoader> loader = MockThreadableLoader::create();
ThreadableLoaderClient* client = nullptr;
InSequence s;
EXPECT_CALL(checkpoint, Call(1));
- EXPECT_CALL(*factory, createInternal(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.release())));
- EXPECT_CALL(*loaderPtr, start(_));
+ EXPECT_CALL(*factory, create(Ref(document()), _, _, _)).WillOnce(DoAll(SaveArg<1>(&client), Return(loader.get())));
+ EXPECT_CALL(*loader, start(_));
EXPECT_CALL(checkpoint, Call(2));
- EXPECT_CALL(*loaderPtr, cancel());
+ EXPECT_CALL(*loader, cancel());
RefPtr<BlobDataHandle> blobDataHandle = createBlobDataHandle("Once upon a time");
std::unique_ptr<WebDataConsumerHandle> handle
« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('K') | « third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp » ('j') | third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698